public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Philippe De Muyter <phdm@macqel.be>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: uClinux development list <uclinux-dev@uclinux.org>,
	Linux/m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [uClinux-dev] [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table
Date: Thu, 7 Apr 2011 10:53:07 +1000	[thread overview]
Message-ID: <4D9D0AF3.9070100@snapgear.com> (raw)
In-Reply-To: <20110406220510.GA17350@frolo.macqel>

On 07/04/11 08:05, Philippe De Muyter wrote:
> On Wed, Apr 06, 2011 at 10:33:07PM +0200, Geert Uytterhoeven wrote:
>> Impact for m68knommu:
>>    - The table is now stored in .data instead of .text,
>
> Do you mean .rodata ?
>
>>    - Removed unused padding at the end of the table.
>>
>> Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org>
>> ---
>> Not tested on m68knommu
>>
>> Questions:
>>    - Why was it .text?
>
> Probably because it is constanti (read-only).

Yes, I suspect that was the original thinking. It has been that way
for a very long time (it is in .text in the 2.4 kernel patches for
this too).

I will test them on m68knommu today, I am sure moving to .data (really
rodata) will be fine.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  parent reply	other threads:[~2011-04-07  0:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 20:33 [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table Geert Uytterhoeven
2011-04-06 22:05 ` [uClinux-dev] " Philippe De Muyter
     [not found] ` <20110406220510.GA17350@frolo.macqel>
2011-04-07  0:53   ` Greg Ungerer [this message]
2011-04-07  2:12     ` Gavin Lambert
     [not found]     ` <000301cbf4c9$40339fc0$c09adf40$@com>
2011-04-07  2:43       ` Greg Ungerer
2011-04-07  3:13         ` Gavin Lambert
2011-04-07  4:14           ` Greg Ungerer
     [not found]           ` <4D9D3A28.9060104@snapgear.com>
2011-04-07  7:04             ` Geert Uytterhoeven
2011-04-07  8:29               ` Andreas Schwab
2011-04-07  8:35                 ` Philippe De Muyter
2011-04-07  8:39                   ` Andreas Schwab
2011-04-13 18:03             ` Geert Uytterhoeven
2011-04-07  1:53 ` Greg Ungerer
2011-04-13 18:16 ` Geert Uytterhoeven
2011-04-17 20:13   ` Arnd Bergmann
2011-04-19  4:32     ` Greg Ungerer
2011-04-19  8:21       ` Arnd Bergmann
2011-04-19  8:30         ` Geert Uytterhoeven
2011-04-19  8:52         ` Arnd Bergmann
2011-04-19 12:26         ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9D0AF3.9070100@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=phdm@macqel.be \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox