Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table

Arnd Bergmann
2011-05-05T06:24:33Z

On Wednesday 04 May 2011, Geert Uytterhoeven wrote:
> Impact for nommu:
> - Store table in .rodata instead of .text,
> - Let kernel/sys_ni.c handle the stubbing of MMU-only syscalls,
> - Implement sys_mremap and sys_nfsservct,
> - Remove unused padding at the end of the table.
>
> Impact for mmu:
> - Store table in .rodata instead of .data.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

What happened to the mmap syscall? IIRC, nommu is pointing to
a different symbol (sys_mmap_pgoff/sys_mmap2).

Did you check the macros in unistd to see if they match the
actual table? I guess it would be a good time to comment out
the ones that are not implemented in either of the two ABIs.

Otherwise, this patch looks good to me.

Arnd