Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table

Arnd Bergmann
2011-05-05T20:37:11Z

On Thursday 05 May 2011 20:44:20 Geert Uytterhoeven wrote:
> On Thu, 5 May 2011, Arnd Bergmann wrote:
> > Did you check the macros in unistd to see if they match the
> > actual table? I guess it would be a good time to comment out
> > the ones that are not implemented in either of the two ABIs.
>
> Like this?

Looks good!

> warning: #warning syscall pselect6 not implemented
> warning: #warning syscall ppoll not implemented
> warning: #warning syscall recvmmsg not implemented
>
> Do we need pselect6 and ppoll? I have vague memories not requiring it.

I'm pretty sure you need them. Glibc provides wrappers for them
when they are not there, but the wrappers not completely reliable.

> recvmmsg is a false positive, as we set __ARCH_WANT_SYS_SOCKETCALL.

This looks really strange. The commit that introduced recvmmsg (a2e27255)
added it to both socketcall and as a separate syscall in a number of
architectures, without a good reason for it. I guess it's too late
to change that now, but we should at least fix the script so we
don't report it missing when socketcall is set.

However, if your unistd.h has defined __NR_recvmmsg before, you should
probably add it to the syscall table, just in case that someone built
a binary with that number.

Arnd