From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: [PATCH] m68k: merge mmu and non-mmu bitops.h Date: Mon, 27 Jun 2011 12:10:40 +1000 Message-ID: <4E07E6A0.1060106@snapgear.com> References: <1308894337-11421-1-git-send-email-gerg@snapgear.com> Reply-To: uClinux development list Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: uclinux-dev-bounces@uclinux.org Errors-To: uclinux-dev-bounces@uclinux.org To: Geert Uytterhoeven Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org, Greg Ungerer List-Id: linux-m68k@vger.kernel.org Hi Geert, On 26/06/11 22:21, Geert Uytterhoeven wrote: > On Fri, Jun 24, 2011 at 07:45, wrote: >> From: Greg Ungerer >> >> The following patch merges the mmu and non-mmu versions of the m68k >> bitops.h files. Now there is a good deal of difference between the two >> files, but none of it is actually an mmu specific difference. It is >> all about the specific m68k/coldfire varient we are targeting. So it >> makes an awful lot of sense to merge these into a single bitops.h. >> >> There is a number of ways I can see to factor this code. The approach >> I have taken here is to keep the various versions of each macro/function >> type together. This means that there is some ifdefery with each to handle >> each CPU type. I have introduced a new config option so that processors >> that support the more advanced bit field instructions can select that. >> It keeps the ifdefs a little cleaner at least. >> >> I have added some comments in a couple of appropriate places to try >> and make it clear what the differences we are dealing with are. >> Specifically the instruction and addressing mode differences we have >> to deal with. >> >> The merged form keeps the same underlying optimizations for each CPU >> type for all the general bit clear/set/change and find bit operations. >> It does switch to using the generic le operations though, instead of >> any local varients. >> >> Build tested on ColdFire, 68328, 68360 (which is cpu32) and 68020+. >> Run tested on ColdFire and ARAnyM. >> >> Signed-off-by: Greg Ungerer > > Thanks! > > If you fix the indentation and spacing problems reported by checkpatch, you > can add my > Acked-by: Geert Uytterhoeven Oh, yeah, look at all that cruft that came through from the old files! Cleaned up now. Thanks for the Acked-by. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev