From: Greg Ungerer <gerg@snapgear.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: merge the mmu and non-mmu kernel/Makefiles
Date: Mon, 15 Aug 2011 11:12:46 +1000 [thread overview]
Message-ID: <4E48728E.3090602@snapgear.com> (raw)
In-Reply-To: <m28vqxdzxl.fsf@igel.home>
Hi Andreas,
On 14/08/11 02:44, Andreas Schwab wrote:
> <gerg@snapgear.com> writes:
>
>> +obj-y$(CONFIG_MMU_SUN3) += dma.o # no, it's not a typo
>
> I'd rather put ifndef CONFIG_MMU_SUN3 around it.
I agree. It is much more obvious what it is doing with the ifndef.
I'll change it over to that.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2011-08-15 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 4:47 [PATCH] m68k: merge the mmu and non-mmu kernel/Makefiles gerg
2011-08-11 6:08 ` [uClinux-dev] " Sam Ravnborg
2011-08-11 6:45 ` Greg Ungerer
2011-08-13 14:27 ` Geert Uytterhoeven
2011-08-15 2:07 ` Greg Ungerer
2011-08-13 16:44 ` Andreas Schwab
2011-08-15 1:12 ` Greg Ungerer [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-23 2:08 gerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E48728E.3090602@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox