From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2/4] fbdev/cirrusfb: Rewrite Zorro graphics card probing Date: Thu, 20 Oct 2011 13:03:09 -0400 Message-ID: <4EA0544D.3070705@garzik.org> References: <1319110945-25684-1-git-send-email-geert@linux-m68k.org> <1319110945-25684-2-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:64975 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab1JTRDM (ORCPT ); Thu, 20 Oct 2011 13:03:12 -0400 In-Reply-To: <1319110945-25684-2-git-send-email-geert@linux-m68k.org> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, "Christian T. Steigies" , linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Ingo_J=FCrgensmann?= On 10/20/2011 07:42 AM, Geert Uytterhoeven wrote: > As indicated by commit a7f4d00a82feb5b311f765bf9522bc55bee0684f ("zorro: > Defer device_register() until all devices have been identified"), cirrusfb > crashes if zorro_find_device() cannot find an expected device. > > Rewrite the Zorro device probe code to make it more robust, easier to > understand, and more extensible. > > Other logical changes: > - For cards that show up as 2 Zorro devices, autoprobe graphics memory > sizes based on the size of the Zorro device containing the graphics > memory. > Acording to the NetBSD sources, this is safe. > > Signed-off-by: Geert Uytterhoeven Acked-by: Jeff Garzik