From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: merge the mmu and non-mmu versions of ptrace.c
Date: Tue, 21 Feb 2012 16:31:27 +1000 [thread overview]
Message-ID: <4F433A3F.7010804@snapgear.com> (raw)
In-Reply-To: <CAMuHMdXE1fHSUpn5neu7VTGZs30q=O-WdC2F-qrt1QKy9TL9Mg@mail.gmail.com>
Hi Geert,
On 19/02/12 20:12, Geert Uytterhoeven wrote:
> On Tue, Feb 7, 2012 at 04:25,<gerg@snapgear.com> wrote:
>> --- a/arch/m68k/kernel/ptrace_mm.c
>> +++ b/arch/m68k/kernel/ptrace.c
>> @@ -277,7 +287,6 @@ asmlinkage void syscall_trace(void)
>> }
>> }
>>
>> -#ifdef CONFIG_COLDFIRE
>> asmlinkage int syscall_trace_enter(void)
>> {
>> int ret = 0;
>> @@ -292,4 +301,3 @@ asmlinkage void syscall_trace_leave(void)
>> if (test_thread_flag(TIF_SYSCALL_TRACE))
>> tracehook_report_syscall_exit(task_pt_regs(current), 0);
>> }
>> -#endif /* CONFIG_COLDFIRE */
>
> Why have you dropped the #ifdef?
Purely to have less "#ifdef"s in the code.
Does bloat the code a little, would you prefer I leave the #ifdef there?
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-02-21 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 3:25 [PATCH] m68k: merge the mmu and non-mmu versions of ptrace.c gerg
2012-02-19 10:12 ` Geert Uytterhoeven
2012-02-21 6:31 ` Greg Ungerer [this message]
2012-02-21 10:12 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F433A3F.7010804@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox