Re: [PATCH 1/5] m68k/atari: EtherNAT - change number of Atari interrupts to make room for EtherNAT interrupts

Michael Schmitz
2012-04-01T22:44:20Z

Hi Geert,

>> Part 1 (this): make room for the EtherNAT interrupts - they appear at
>> vectors 0xc3 (USB ISP1160) and 0xc4 (SMC91C111)
>
> Is there any specific reason you cannot use atari_register_vme_int(), like
> drivers/net/ethernet/amd/atarilance.c, to avoid increasing NR_IRQS?

>From what I read in atari_register_vme_int(), it returns the next free
VME interrupt starting at VME_SOURCE_BASE. This required the vector
number to be programmable in the correspomding VME device.

To the best of my knowledge, vector numbers are fixed (0xc3 and 0xc4)
for the EtherNAT.

I definitely need to increase NR_IRQS - it might be better to leave
VME_MAX_SOURCES unchanged and change the NUM_ATARI_SOURCES definition
above instead.

I'm uncertain whether the complicated definition of NUM_ATARI_SOURCES
is needed anymore - are the IRQ_VECTOR_TO_SOURCE and
IRQ_SOURCE_TO_VECTOR macros still used anywhere?

Cheers,

Michael