Re: [PATCH 1/5] m68k/atari: EtherNAT - change number of Atari interrupts to make room for EtherNAT interrupts

Michael Schmitz
2012-04-02T22:29:30Z

Hi Geert,

>> I'm uncertain whether the complicated definition of NUM_ATARI_SOURCES
>> is needed anymore - are the IRQ_VECTOR_TO_SOURCE and
>> IRQ_SOURCE_TO_VECTOR macros still used anywhere?
>
> Only the latter:
>
> drivers/net/ethernet/amd/atarilance.c:          IO->ivec =
> IRQ_SOURCE_TO_VECTOR(dev->irq);
> drivers/net/ethernet/amd/atarilance.c:          *RIEBL_IVEC_ADDR =
> IRQ_SOURCE_TO_VECTOR(dev->irq);

OK, so we'll need to retain that.

The definition of NUM_ATARI_SOURCES will need to be changed again;
we'd best hardcode it to 140:
For one, allowing for 152 VME interrupts will exceed the boundaries of
the allocated bitmap (i.e. trash other memory).
We won't need the full 200 either (I seem to have got the EtherNAT
source numbers wrong in my earlier patch).

I'll send patches for these fixes later.

Cheers,

Michael