From: Michael Schmitz <schmitzmic@googlemail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-m68k@vger.kernel.org
Subject: Re: [PATCH 1/2] m68k: correct the Atari ALLOWINT definition
Date: Thu, 19 Apr 2012 21:29:58 +1200 [thread overview]
Message-ID: <4F8FDB16.3020502@gmail.com> (raw)
In-Reply-To: <20367.17904.199202.88993@pilspetsen.it.uu.se>
Mikael Pettersson wrote:
> The fix is simple: define ALLOWINT as ~0x500 instead. This makes
> arch_local_irq_enable() consistent with default_idle(), and prevents
> the !irqs_disabled() problems for ipl 3 interrupts.
>
> Tested on Atari running in an Aranym VM.
>
Tested on my Falcon/CT60.
Michael
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
> Since ipl is interpreted by HW as a numerical level, the current
> simple-minded bit masking operations in arch_local_irq_enable(),
> arch_irqs_disabled_flags(), and entry_mm.S aren't really correct,
> but only Atari is affected, and it doesn't seem to hurt in practice.
>
> --- linux-3.4-rc3/arch/m68k/include/asm/entry.h.~1~ 2012-03-19 14:06:52.000000000 +0100
> +++ linux-3.4-rc3/arch/m68k/include/asm/entry.h 2012-04-18 22:07:52.000000000 +0200
> @@ -33,8 +33,8 @@
>
> /* the following macro is used when enabling interrupts */
> #if defined(MACH_ATARI_ONLY)
> - /* block out HSYNC on the atari */
> -#define ALLOWINT (~0x400)
> + /* block out HSYNC = ipl 2 on the atari */
> +#define ALLOWINT (~0x500)
> #define MAX_NOINT_IPL 3
> #else
> /* portable version */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-04-19 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 22:53 [PATCH 1/2] m68k: correct the Atari ALLOWINT definition Mikael Pettersson
2012-04-19 9:29 ` Michael Schmitz [this message]
2012-04-19 11:03 ` Mikael Pettersson
2012-04-23 0:51 ` Michael Schmitz
2012-04-22 8:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FDB16.3020502@gmail.com \
--to=schmitzmic@googlemail.com \
--cc=linux-m68k@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox