From: Greg Ungerer <gerg@snapgear.com>
To: Alex LI <alexlihk@hotmail.com>
Cc: uClinux development list <uclinux-dev@uclinux.org>,
mohamed nabil <m.nabil.hafez@gmail.com>,
linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup
Date: Thu, 26 Apr 2012 11:07:45 +1000 [thread overview]
Message-ID: <4F989FE1.1090109@snapgear.com> (raw)
In-Reply-To: <BLU0-SMTP466FE400E21A67A2EC82F91D9240@phx.gbl>
Hi Alex,
On 04/26/2012 10:53 AM, Alex LI wrote:
> You sent 50 mails in 1 min.
I sent 23. And both list archives (linux-m68k and uclinux-dev) only
show the 23 emails.
Maybe the uclinux-dev reflecter is sending dupes to list recpients?
Regards
Greg
> Sent from my Sony Ericsson Xperia arc S
>
> Greg Ungerer<gerg@snapgear.com> ?:
>
>> On 04/26/2012 10:36 AM, mohamed nabil wrote:
>>> that's a Fucking spam man !!
>>
>> Huh?
>>
>> Thats how open source development works. If you don't like it don't
>> subscribe to a developers list.
>>
>> Regards
>> Greg
>>
>>
>>
>>> On Thu, Apr 26, 2012 at 2:26 AM,<gerg@snapgear.com
>>> <mailto:gerg@snapgear.com>> wrote:
>>>
>>> From: Greg Ungerer<gerg@uclinux.org<mailto:gerg@uclinux.org>>
>>>
>>> The GPIO data struct setup is now the only remaining code in the
>>> platform
>>> gpio.c file. So move it to the platform config.c code and remove the
>>> gpio.c
>>> file.
>>>
>>> Signed-off-by: Greg Ungerer<gerg@uclinux.org<mailto:gerg@uclinux.org>>
>>> ---
>>> arch/m68k/platform/532x/Makefile | 2 +-
>>> arch/m68k/platform/532x/config.c | 25 ++++++++++++++++++++++
>>> arch/m68k/platform/532x/gpio.c | 43
>>> --------------------------------------
>>> 3 files changed, 26 insertions(+), 44 deletions(-)
>>> delete mode 100644 arch/m68k/platform/532x/gpio.c
>>>
>>> diff --git a/arch/m68k/platform/532x/Makefile
>>> b/arch/m68k/platform/532x/Makefile
>>> index ce01669..c0d8cf8 100644
>>> --- a/arch/m68k/platform/532x/Makefile
>>> +++ b/arch/m68k/platform/532x/Makefile
>>> @@ -15,4 +15,4 @@
>>> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
>>>
>>> #obj-y := config.o usb-mcf532x.o spi-mcf532x.o
>>> -obj-y := config.o gpio.o
>>> +obj-y := config.o
>>> diff --git a/arch/m68k/platform/532x/config.c
>>> b/arch/m68k/platform/532x/config.c
>>> index 2bec347..a4dd3d8 100644
>>> --- a/arch/m68k/platform/532x/config.c
>>> +++ b/arch/m68k/platform/532x/config.c
>>> @@ -26,10 +26,35 @@
>>> #include<asm/mcfsim.h>
>>> #include<asm/mcfuart.h>
>>> #include<asm/mcfdma.h>
>>> +#include<asm/mcfgpio.h>
>>> #include<asm/mcfwdebug.h>
>>>
>>> /***************************************************************************/
>>>
>>> +struct mcf_gpio_chip mcf_gpio_chips[] = {
>>> + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR,
>>> MCFEPORT_EPPDR),
>>> + MCFGPF(FECH, 8, 8),
>>> + MCFGPF(FECL, 16, 8),
>>> + MCFGPF(SSI, 24, 5),
>>> + MCFGPF(BUSCTL, 32, 4),
>>> + MCFGPF(BE, 40, 4),
>>> + MCFGPF(CS, 49, 5),
>>> + MCFGPF(PWM, 58, 4),
>>> + MCFGPF(FECI2C, 64, 4),
>>> + MCFGPF(UART, 72, 8),
>>> + MCFGPF(QSPI, 80, 6),
>>> + MCFGPF(TIMER, 88, 4),
>>> + MCFGPF(LCDDATAH, 96, 2),
>>> + MCFGPF(LCDDATAM, 104, 8),
>>> + MCFGPF(LCDDATAL, 112, 8),
>>> + MCFGPF(LCDCTLH, 120, 1),
>>> + MCFGPF(LCDCTLL, 128, 8),
>>> +};
>>> +
>>> +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips);
>>> +
>>> +/***************************************************************************/
>>> +
>>> #ifdef CONFIG_SPI_COLDFIRE_QSPI
>>>
>>> static void __init m532x_qspi_init(void)
>>> diff --git a/arch/m68k/platform/532x/gpio.c
>>> b/arch/m68k/platform/532x/gpio.c
>>> deleted file mode 100644
>>> index 3e1b71d..0000000
>>> --- a/arch/m68k/platform/532x/gpio.c
>>> +++ /dev/null
>>> @@ -1,43 +0,0 @@
>>> -/*
>>> - * Coldfire generic GPIO support
>>> - *
>>> - * (C) Copyright 2009, Steven King<sfking@fdwdc.com
>>> <mailto:sfking@fdwdc.com>>
>>> - *
>>> - * This program is free software; you can redistribute it and/or modify
>>> - * it under the terms of the GNU General Public License as published by
>>> - * the Free Software Foundation; version 2 of the License.
>>> - *
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> - * GNU General Public License for more details.
>>> -*/
>>> -
>>> -#include<linux/kernel.h>
>>> -#include<linux/init.h>
>>> -
>>> -#include<asm/coldfire.h>
>>> -#include<asm/mcfsim.h>
>>> -#include<asm/mcfgpio.h>
>>> -
>>> -struct mcf_gpio_chip mcf_gpio_chips[] = {
>>> - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR,
>>> MCFEPORT_EPPDR),
>>> - MCFGPF(FECH, 8, 8),
>>> - MCFGPF(FECL, 16, 8),
>>> - MCFGPF(SSI, 24, 5),
>>> - MCFGPF(BUSCTL, 32, 4),
>>> - MCFGPF(BE, 40, 4),
>>> - MCFGPF(CS, 49, 5),
>>> - MCFGPF(PWM, 58, 4),
>>> - MCFGPF(FECI2C, 64, 4),
>>> - MCFGPF(UART, 72, 8),
>>> - MCFGPF(QSPI, 80, 6),
>>> - MCFGPF(TIMER, 88, 4),
>>> - MCFGPF(LCDDATAH, 96, 2),
>>> - MCFGPF(LCDDATAM, 104, 8),
>>> - MCFGPF(LCDDATAL, 112, 8),
>>> - MCFGPF(LCDCTLH, 120, 1),
>>> - MCFGPF(LCDCTLL, 128, 8),
>>> -};
>>> -
>>> -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips);
>>> --
>>> 1.7.0.4
>>>
>>> _______________________________________________
>>> uClinux-dev mailing list
>>> uClinux-dev@uclinux.org<mailto:uClinux-dev@uclinux.org>
>>> http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
>>> This message was resent by uclinux-dev@uclinux.org
>>> <mailto:uclinux-dev@uclinux.org>
>>> To unsubscribe see:
>>> http://mailman.uclinux.org/mailman/options/uclinux-dev
>>>
>>>
>>>
>>>
>>> --
>>> ______
>>> Mohamed Nabil Hafez
>>> Embedded Software Engineer
>>>
>>
>>
>> --
>> ------------------------------------------------------------------------
>> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
>> SnapGear Group, McAfee PHONE: +61 7 3435 2888
>> 8 Gardner Close, FAX: +61 7 3891 3630
>> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
>> _______________________________________________
>> uClinux-dev mailing list
>> uClinux-dev@uclinux.org
>> http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
>> This message was resent by uclinux-dev@uclinux.org
>> To unsubscribe see:
>> http://mailman.uclinux.org/mailman/options/uclinux-dev
>>
> \x13???\x1c?&?~?&?\x18??+-???\x17??w??????m?b??f??"??^n?r???z?\x1a??h????&??\x1e?G???h?\x03(????j"??\x1a?^[m?????z?????f???h???~?m?
>
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-04-26 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 0:53 [uClinux-dev] [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup Alex LI
2012-04-26 1:07 ` Greg Ungerer [this message]
2012-04-26 1:10 ` mohamed nabil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F989FE1.1090109@snapgear.com \
--to=gerg@snapgear.com \
--cc=alexlihk@hotmail.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=m.nabil.hafez@gmail.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox