public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Edward Shao <laface.tw@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: Quest about m68knommu check in top of kernel Makefile.
Date: Fri, 27 Apr 2012 16:30:52 +1000	[thread overview]
Message-ID: <4F9A3D1C.4030305@snapgear.com> (raw)
In-Reply-To: <CAKjXMyAvBMgPEsdiO=F1oLHt-_DBxdoz9+G=AOsejn5SLfDS_g@mail.gmail.com>

Hi Edward,

On 26/04/12 22:34, Edward Shao wrote:
> I have a question about ($(ARCH),m68knommu) check in top of kernel Makefile.
> Any reason not to change SRCARCH but change hdr-arch?
>
> If I modify the makefile as below, is it ok?
>
> diff --git a/Makefile b/Makefile
> index afc868e..396ed28 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -228,13 +228,14 @@ ifeq ($(ARCH),tilegx)
> 	SRCARCH := tile
>  endif
>
> -# Where to locate arch specific headers
> -hdr-arch	:= $(SRCARCH)
> -
> +# Additional ARCH settings for m86k
>  ifeq ($(ARCH),m68knommu)
> -	hdr-arch	:= m68k
> +	SRCARCH := m68k
>  endif
>
> +# Where to locate arch specific headers
> +hdr-arch	:= $(SRCARCH)
> +
>  KCONFIG_CONFIG ?= .config
>  export KCONFIG_CONFIG

I think it better to just remove the whole m68knommu conditional,
since there is not longer a separate m68knommu arch branch.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2012-04-27  6:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 12:34 Quest about m68knommu check in top of kernel Makefile Edward Shao
2012-04-27  6:30 ` Greg Ungerer [this message]
2012-04-27  6:51   ` Edward Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9A3D1C.4030305@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=laface.tw@gmail.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox