From: Greg Ungerer <gerg@snapgear.com>
To: Luis Alves <ljalvs@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH] unaligned.h fix for M68000 core
Date: Mon, 14 May 2012 11:10:10 +1000 [thread overview]
Message-ID: <4FB05B72.7030901@snapgear.com> (raw)
In-Reply-To: <1336927182-3505-1-git-send-email-ljalvs@gmail.com>
Hi Luis,
On 14/05/12 02:39, Luis Alves wrote:
> This patch fixes unaligned memory access for the 68000 core based cpu's.
>
> Some time ago, my cpu (68000) was raising address/bus error's when mounting cifs shares (didn't bother to debug it at the time).
> After developing the MMC/SD card driver I was having the same issue when mounting the vfat fs.
>
> I've traced the issue down to the 'unaligned.h' file. (I guess nobody has ever used unaligned.h back in the 68328 'era'.
Looks good, thanks.
I'll apply it to the m68knommu git tree.
Regards
Greg
> Signed-off-by: Luis Alves<ljalvs@gmail.com>
> ---
> arch/m68k/include/asm/unaligned.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/unaligned.h b/arch/m68k/include/asm/unaligned.h
> index 019caa7..f4043ae 100644
> --- a/arch/m68k/include/asm/unaligned.h
> +++ b/arch/m68k/include/asm/unaligned.h
> @@ -2,7 +2,7 @@
> #define _ASM_M68K_UNALIGNED_H
>
>
> -#ifdef CONFIG_COLDFIRE
> +#if defined(CONFIG_COLDFIRE) || defined(CONFIG_M68000)
> #include<linux/unaligned/be_struct.h>
> #include<linux/unaligned/le_byteshift.h>
> #include<linux/unaligned/generic.h>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2012-05-14 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <68000 unaligned.h>
2012-05-13 16:39 ` [PATCH] unaligned.h fix for M68000 core Luis Alves
2012-05-13 16:40 ` Luis Alves
[not found] ` <1336927182-3505-1-git-send-email-ljalvs@gmail.com>
2012-05-14 1:10 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB05B72.7030901@snapgear.com \
--to=gerg@snapgear.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=ljalvs@gmail.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).