From: Greg Ungerer <gerg@snapgear.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: fix ColdFire clear cache operation
Date: Tue, 10 Jul 2012 22:50:40 +1000 [thread overview]
Message-ID: <4FFC2520.4030604@snapgear.com> (raw)
In-Reply-To: <m2629w5bub.fsf@igel.home>
Hi Andreas,
On 07/10/2012 05:12 PM, Andreas Schwab wrote:
> <gerg@snapgear.com> writes:
>
>> +static inline void clear_cf_icache(unsigned long start, unsigned long end)
>> +{
>> + __asm__ __volatile__ (
>> + "movel %0,%%d0\n\t"
>> + "movec %%d0,%%cacr\n\t"
>> + "nop\n\t"
>> + :
>> + : "i" (CACHE_MODE | CACR_ICINVA | CACR_BCINVA)
>
> Why not "r"?
Yes, that is better. I will revise and repost.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2012-07-10 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 6:41 [PATCH] m68k: fix ColdFire clear cache operation gerg
2012-07-10 7:12 ` Andreas Schwab
2012-07-10 12:50 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC2520.4030604@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).