From: Greg Ungerer <gerg@snapgear.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH v2] m68k: fix ColdFire clear cache operation
Date: Thu, 12 Jul 2012 11:50:51 +1000 [thread overview]
Message-ID: <4FFE2D7B.8090405@snapgear.com> (raw)
In-Reply-To: <20120711155148.GA26577@frolo.macqel>
Hi Philippe,
On 12/07/12 01:51, Philippe De Muyter wrote:
> On Wed, Jul 11, 2012 at 10:37:16AM +1000, gerg@snapgear.com wrote:
>
>> + __asm__ __volatile__ (
>> + "movec %0,%%cacr\n\t"
>> + "nop\n\t"
>
> This could be written as
>
> "movec %0,%%cacr; nop"
It could, but IMHO that is not as clear. One instruction per line
is easier to read.
> i.e. :
> final "\n\t" is useless
Yep, I will remove that.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-07-12 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 0:37 [PATCH v2] m68k: fix ColdFire clear cache operation gerg
2012-07-11 15:51 ` Philippe De Muyter
2012-07-12 1:50 ` Greg Ungerer [this message]
2012-07-16 19:13 ` Geert Uytterhoeven
2012-07-17 6:03 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFE2D7B.8090405@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).