From: Greg Ungerer <gerg@snapgear.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH v2 0/2] net: support for NS8390 based ethernet on ColdFire CPU boards
Date: Fri, 13 Jul 2012 11:05:34 +1000 [thread overview]
Message-ID: <4FFF745E.8010202@snapgear.com> (raw)
In-Reply-To: <20120712.075531.836132484757271226.davem@davemloft.net>
Hi David,
On 13/07/12 00:55, David Miller wrote:
> From: <gerg@snapgear.com>
> Date: Thu, 5 Jul 2012 09:49:58 +1000
>
>>
>> This is version 2 of patches that add platform support for using the NS8390
>> based ethernet ports used on some ColdFire CPU boards. This version
>> incorporates only minor changes from the first.
>>
>> Patches to use these NS8390 devices on ColdFire boards have existed
>> out-of-tree for years. Some of the base IO definitions (those in
>> arch/m68k/include/asm/mcfne.h) have been in mainline, but unused for most
>> of that time.
>>
>> The first patch just neatens up mcfne.h (moving it to mcf8390.h). The
>> second patch is the platform driver. The first patch would normaly just
>> go through the m68knommu git tree, but I figured keeping these together made
>> more sense.
>
> Applied, thanks.
Great, thanks.
> Can you explain why we've had this completely unused header
> file mcfne.h in the tree? Was it used by some external driver
> sources that were never merged?
That mcfne.h came in with all the other non-mmu m68k headers back in
the 2.5 kernel days. It was used by some external patches that modified
the existing ne.c ethernet driver. But they were really hacks, and a
bit ugly at that.
It was a recently pointed out by Paul Bolle on the m68k list that this
file still was unused in mainline, and that prompted me to actually sort
out the 8390 support on these boards and get it done right.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2012-07-13 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 23:49 [PATCH v2 0/2] net: support for NS8390 based ethernet on ColdFire CPU boards gerg
2012-07-04 23:49 ` [PATCH v2 1/2] m68knommu: move the badly named mcfne.h to a better mcf8390.h gerg
2012-07-04 23:50 ` [PATCH v2 2/2] net: add support for NS8390 based eth controllers on some ColdFire CPU boards gerg
2012-07-12 14:55 ` [PATCH v2 0/2] net: support for NS8390 based ethernet on " David Miller
2012-07-13 1:05 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF745E.8010202@snapgear.com \
--to=gerg@snapgear.com \
--cc=davem@davemloft.net \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).