From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michael Schmitz" <schmitzmic@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: linux-m68k@vger.kernel.org, "Geert Uytterhoeven" <geert@linux-m68k.org>
Subject: Re: [PATCH] scsi: gvp11: add module parameter for DMA transfer bit mask
Date: Tue, 29 Aug 2023 18:05:22 -0400 [thread overview]
Message-ID: <4a7d0dda-c24f-4875-892f-c8c5ef700882@app.fastmail.com> (raw)
In-Reply-To: <20230829214517.14448-1-schmitzmic@gmail.com>
On Tue, Aug 29, 2023, at 17:45, Michael Schmitz wrote:
> SCSI boards on Amiga. There now is no way to set a non-default
> DMA mask on these boards.
It might help to mention here in which cases the default mask
is actually wrong.
> +module_param(gvp11_xfer_mask, int, 0444);
> +MODULE_PARM_DESC(gvp11_xfer_mask, "DMA mask (0xff000000 == 24 bit DMA)");
> +
I think the comment is the wrong way round, it should be
0x00ffffff in this case, which also matches the default
mask for ZORRO_PROD_GVP_SERIES_II, in the match table:
static struct zorro_device_id gvp11_zorro_tbl[] = {
{ ZORRO_PROD_GVP_COMBO_030_R3_SCSI, ~0x00ffffff },
{ ZORRO_PROD_GVP_SERIES_II, ~0x00ffffff },
{ ZORRO_PROD_GVP_GFORCE_030_SCSI, ~0x01ffffff },
{ ZORRO_PROD_GVP_A530_SCSI, ~0x01ffffff },
{ ZORRO_PROD_GVP_COMBO_030_R4_SCSI, ~0x01ffffff },
{ ZORRO_PROD_GVP_A1291, ~0x07ffffff },
{ ZORRO_PROD_GVP_GFORCE_040_SCSI_1, ~0x07ffffff },
{ 0 }
};
Arnd
next prev parent reply other threads:[~2023-08-29 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 21:45 [PATCH] scsi: gvp11: add module parameter for DMA transfer bit mask Michael Schmitz
2023-08-29 22:05 ` Arnd Bergmann [this message]
2023-08-29 22:25 ` Michael Schmitz
2023-08-30 0:14 ` Arnd Bergmann
2023-08-30 0:47 ` Michael Schmitz
2023-08-30 7:32 ` Geert Uytterhoeven
2023-08-30 7:52 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a7d0dda-c24f-4875-892f-c8c5ef700882@app.fastmail.com \
--to=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox