Re: [PATCH] m68k: add generic atomic64_t support

Geert Uytterhoeven
2012-08-12T14:47:31Z

Hi Fengguang,

On Sun, Aug 12, 2012 at 4:23 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> This fixes build errors like:
>
> fs/namespace.c:2290:1: error: unknown type name 'atomic64_t'
> fs/namespace.c:2290:1: error: implicit declaration of function 'ATOMIC64_INIT' [-Werror=implicit-function-declaration]
> fs/namespace.c:2290:1: error: initializer element is not constant
> fs/namespace.c: In function 'alloc_mnt_ns':
> fs/namespace.c:2299:2: error: implicit declaration of function 'atomic64_add_return' [-Werror=implicit-function-declaration]

> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> arch/m68k/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux.orig/arch/m68k/Kconfig 2012-08-12 21:15:49.730533572 +0800
> +++ linux/arch/m68k/Kconfig 2012-08-12 22:19:56.202624988 +0800
> @@ -12,6 +12,7 @@ config M68K
> select FPU if MMU
> select ARCH_WANT_IPC_PARSE_VERSION
> select ARCH_USES_GETTIMEOFFSET if MMU && !COLDFIRE
> + select GENERIC_ATOMIC64

For several CPU types (68020/68030/68040/68080), this is already selected in
arch/m68k/Kconfig.cpu
So probably this select should be moved to cover more CPU types?

For which config do you get this build error? I can't seem to trigger it in
current mainline nor -next with m5475evb_defconfig.
Does it depend on additional patches to introduce more atomic64 uses?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds