Re: [PATCH] m68k: merge arch free memory functions into a single function

Greg Ungerer
2012-12-03T06:25:42Z

Hi Finn,

On 01/12/12 13:49, Finn Thain wrote:
> On Fri, 30 Nov 2012, gerg@snapgear.com wrote:
>
>> - pr_notice("Freeing unused kernel memory: %luk freed (0x%x - 0x%x)\n",
>> - (addr - (unsigned long) __init_begin) >> 10,
>> - (unsigned int) __init_begin, (unsigned int) __init_end);
>> + pr_notice("Freeing %s memory: %dk freed (0x%lx-0x%lx)\n", name,
>> + pages << (PAGE_SHIFT - 10), start, end);
>
> Perhaps "Freed %d KiB %s memory: 0x%lx - 0x%lx\n" is better (a tad shorter
> and has the correct unit).

Sure. New patch coming up.

Thanks
Greg

------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com