From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schmitz Subject: Re: esp_scsi QTAG in FAS216 Date: Mon, 31 Oct 2016 21:03:44 +1300 Message-ID: <50ffb9f6-ebe0-9e87-1244-25dfb2ec01d2@gmail.com> References: <20140413.221414.853080853067673824.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:34439 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761999AbcJaIDx (ORCPT ); Mon, 31 Oct 2016 04:03:53 -0400 In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Finn Thain , David Miller Cc: jongk@linux-m68k.org, tuomas.vainikka@aalto.fi, geert@linux-m68k.org, linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org Hi Finn, Am 30.10.2016 um 15:33 schrieb Finn Thain: > > On Sat, 29 Oct 2016, I wrote: > >> >> On Sun, 13 Apr 2014, David Miller wrote: >> >>> >>> But oddly in the NCR53CX docs: >>> >>> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt >>> >>> it speaks as if ESP_CONFIG3_TMS and ESP_CONFIG3_TENB are merely finer >>> grained versions of config2 register setting ESP_CONFIG2_SCSI2ENAB, >>> which enables both features. >> >> Yes, so setting the ESP_CONFIG2_SCSI2ENAB bit is correct. The only >> problem is, doesn't the ESP_CONFIG3_TMS bit get cleared again later, >> when the CONFIG3 register is written to? >> > > Nevermind my question. To falsify my own theory, I see that > ESP_CONFIG3_TMS == ESP_CONFIG3_FCLK, and thus esp_scsi does actually set > the relevant bit, and therefore "the FSC can receive 3-byte messages > during businitiated select with ATN." >>From my reading of the quoted docs,ESP_CONFIG3_TMS is valid for FAS100A (and later?). What esp_scsi sets (for FAS236 chips) is fast SCSI clock mode. The relevant bit for three byte message support for Mac and Amiga ESP hardware should be ESP_CONFIG3_TENB. I had tried to set that bit in zorro_esp_slave_configure but had not done a proper job of it - I'd only set esp->config3 and forgot to set tp->esp_config3. Time to retest this ... Cheers, Michael