Re: m68k build regression

[Alex Courbot <acourbot@nvidia.com>]

On 04/05/2013 07:49 AM, Linus Walleij wrote:
> On Fri, Apr 5, 2013 at 12:39 PM, Bityutskiy, Artem
> <artem.bityutskiy@intel.com> wrote:
>
>> starting from 3.9-rc1 one of my m68k configurations does not build,
>> which is a regression. The configuration is attached. I build with
>> W=1. I did not look at the details, just shooting a bug report.
>>
>> drivers/gpio/devres.c: In function 'devm_gpio_request_one':
>> drivers/gpio/devres.c:90:2: error: implicit declaration of function 'gpio_request_one' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>> make[3]: *** [drivers/gpio/devres.o] Error 1
>
> Somehow GPIO_DEVRES get selected,
> m68k is using GENERIC_GPIO but not GPIOLIB, so
> devres.c include <linux/gpio.h> which includes <asm/gpio.h>
> as the arch has CONFIG_ARCH_HAVE_CUSTOM_GPIO_H.
>
> So to use the devres facility arch/m68k/include/asm/gpio.h
> needs to provide gpio_request_one().
>
> Which it doesn't and thus fails.
>
> Did some driver you're using start to use
> devm_gpio_request_one() recently?
>
> I vaguely remember Alexandre looking into things like this
> so adding him...

I know OpenRisc had an issue with devres.c (CC Jonas), please look at 
commit d4cb776f for the fix. I don't think my changes for 3.9 are 
responsible for this, they only deal with gpiolib's internals and not 
with header files, so they should be noop for platforms only using 
GENERIC_GPIO.

I'd recommend doing the same as OpenRisc (turning GENERIC_GPIO and 
ARCH_WANT_OPTIONAL_GPIOLIB into ARCH_REQUIRE_GPIOLIB), anyway 
GENERIC_GPIO is being removed for 3.10, so you better get used to using 
gpiolib from now on. :)

Alex.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------