From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] net/7990: Make lance_private.name const
Date: Wed, 13 Nov 2013 03:04:15 +0300 [thread overview]
Message-ID: <5282C1FF.2090608@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdVn6MFbXgdE_teYW10OfYBjyZsN7v2yTTAsKj0kXao7Hw@mail.gmail.com>
On 11/13/2013 01:44 AM, Geert Uytterhoeven wrote:
>>>>> @@ -100,7 +100,7 @@ struct lance_init_block {
>>>>> */
>>>>> struct lance_private
>>>>> {
>>>>> - char *name;
>>>>> + const char *name;
>>>> Indent with tab, not spaces, please.
>>> This whole file is %99 space indentation, you really can't blame
>>> Geert for this.
>> It's never late to fix some.
> That would be a separate patch. Care to create and send it?
I wasn't telling you to fix all of them, just the ones you touched anyway.
I don't see why the separate patch is needed for that.
>> And remember about checkpatch.pl which was hardly content with the patch.
> Only because checkpatch looks at the _new_ lines, and doesn't compare the
> styles of the old and new lines.
Care to fix it? :-)
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
next prev parent reply other threads:[~2013-11-12 23:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 19:14 [PATCH] net/7990: Make lance_private.name const Geert Uytterhoeven
2013-11-12 22:04 ` Sergei Shtylyov
2013-11-12 21:12 ` David Miller
2013-11-12 23:40 ` Sergei Shtylyov
2013-11-12 22:44 ` Geert Uytterhoeven
2013-11-12 23:16 ` David Miller
2013-11-13 8:54 ` Geert Uytterhoeven
2013-11-13 20:13 ` David Miller
2013-11-14 8:37 ` Geert Uytterhoeven
2013-11-14 9:11 ` David Miller
2013-11-13 0:04 ` Sergei Shtylyov [this message]
2013-11-12 23:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282C1FF.2090608@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox