From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] mm: Make {,set}page_address() static inline if WANT_PAGE_VIRTUAL Date: Wed, 15 Jan 2014 02:31:50 -0800 Message-ID: <52D66396.5050104@roeck-us.net> References: <1389778426-14836-1-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1389778426-14836-1-git-send-email-geert@linux-m68k.org> Sender: sparclinux-owner@vger.kernel.org To: Geert Uytterhoeven , Andrew Morton , "Michael S. Tsirkin" Cc: linux-mm@kvack.org, linux-bcache@vger.kernel.org, Vineet Gupta , sparclinux@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-m68k@vger.kernel.org On 01/15/2014 01:33 AM, Geert Uytterhoeven wrote: > {,set}page_address() are macros if WANT_PAGE_VIRTUAL. > If !WANT_PAGE_VIRTUAL, they're plain C functions. > > If someone calls them with a void *, this pointer is auto-converted t= o > struct page * if !WANT_PAGE_VIRTUAL, but causes a build failure on > architectures using WANT_PAGE_VIRTUAL (arc, m68k and sparc): > > drivers/md/bcache/bset.c: In function =E2=80=98__btree_sort=E2=80=99: > drivers/md/bcache/bset.c:1190: warning: dereferencing =E2=80=98void *= =E2=80=99 pointer > drivers/md/bcache/bset.c:1190: error: request for member =E2=80=98vir= tual=E2=80=99 in something not a structure or union > > Convert them to static inline functions to fix this. There are alread= y > plenty of users of struct page members inside , so there= 's no > reason to keep them as macros. > > Signed-off-by: Geert Uytterhoeven Tested-by: Guenter Roeck That also fixes the problem seen in stable-queue for 3.10 and 3.12, so it may be a better fix for the problem seen there than the patch provided by Michael. Guenter -- To unsubscribe from this list: send the line "unsubscribe sparclinux" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html