Re: [PATCH, RFC 02/30] scsi: atari_scsi: fix sleep_on race

Michael Schmitz
2014-01-27T08:28:13Z

Geert,

I will submit patches to the Atari SCSI driver based on Arnd's patch
later this week. Has Arnd's initial patch made it into mainline yet?

While working on the driver, I noticed my Falcon ran into a memory
squeeze once a day, resulting in oom-killing processes and rendering the
system unusable. Most likely culprit to trigger this is the daily
updatedb run. This sort of trouble started pretty much with my work on
the SCSI driver, based on commit
aa5311c454ed0ff959adca29c65be2157f52a84c (3.13-rc7). Do you know of any
memory leak affecting m68k, introduced between last November and 3.13-rc7?

Cheers,

Michael
>> Arnd,
>>
>> your patch breaks the Atari NCR5380 SCSI driver (easily verified using
>> ARAnyM). Last console output:
>>
>>
>
> Thanks so much for testing and sorry for your troubles. It seems I
> got the wrong polarity on at least one of the conditions when converting
> from a while()-style loop to an until()-style wait_event loop.
> I did double-check all the patches before, but this one must have
> slipped through because the use is so obscure.
>
> Arnd
>
>