public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gregungerer@westnet.com.au>
To: Daniel Palmer <danieruru@gmail.com>
Cc: linux-m68k@vger.kernel.org
Subject: Re: Getting stuck during boot on a 68VZ328 (DragonBallVZ).
Date: Thu, 03 Apr 2014 22:46:47 +1000	[thread overview]
Message-ID: <533D5837.803@westnet.com.au> (raw)
In-Reply-To: <CAO64nm70mwZijE4x4-+kcxckUy78DONPRYquxUdFFzGzS47xbw@mail.gmail.com>

Hi Daniel,

On 02/04/14 23:19, Daniel Palmer wrote:
> On Wed, Apr 2, 2014 at 9:26 PM, Greg Ungerer <gregungerer00@gmail.com> wrote:
>> Can you create patches and send them here?
>> Clean neat patches are easily pushed up-stream to the kernel.
>
> I'll try to do this in the next few days. I'm not sure what the
> layering of the patches should be. I know that changing too much in
> one patch is a no no.

What you want is each patch to be one logical change. Small is good,
makes them easy to review. Sometimes they may need to be large. What
you don't want is a mixture of things thrown together (multiple bug
fixes, formatting changes, new features, etc).


> Maybe the first patch would just be to make EZ and VZ chips bootable
> again by adding in the lines to setup the PLL and setting up
> mach_shed_init in platform/68000/m68[EZ|VZ]328.c?

Sure, sounds good.


> Then if Finn's changes for earlyprintk are merged it would be simple
> to add the code to support that for the Dragonball chips as another
> patch.

Regards
Greg

      reply	other threads:[~2014-04-03 12:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 17:58 Getting stuck during boot on a 68VZ328 (DragonBallVZ) Daniel Palmer
2014-03-28  6:38 ` Daniel Palmer
2014-03-28 10:17   ` Luis Alves
2014-04-02  1:42   ` Daniel Palmer
2014-04-02  5:06     ` Finn Thain
2014-04-02  5:35       ` Daniel Palmer
2014-04-02 10:47         ` Luis Alves
2014-04-02 11:33           ` Daniel Palmer
2014-04-02 12:02           ` Finn Thain
2014-04-02 12:31           ` Greg Ungerer
2014-04-02 12:26     ` Greg Ungerer
2014-04-02 13:19       ` Daniel Palmer
2014-04-03 12:46         ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D5837.803@westnet.com.au \
    --to=gregungerer@westnet.com.au \
    --cc=danieruru@gmail.com \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox