From: Greg Ungerer <gregungerer@westnet.com.au>
To: Daniel Palmer <danieruru@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH v2 1/2] m68k: fix a compiler warning when building for DragonBall
Date: Tue, 08 Apr 2014 17:13:45 +1000 [thread overview]
Message-ID: <5343A1A9.1000102@westnet.com.au> (raw)
In-Reply-To: <1396685145-12935-1-git-send-email-danieruru@gmail.com>
Hi Daniel,
On 05/04/14 18:05, Daniel Palmer wrote:
> In file included from arch/m68k/kernel/setup.c:4:0:
> arch/m68k/kernel/setup_no.c:70:0: warning: "CPU_NAME" redefined [enabled by default]
> #define CPU_NAME "MC68VZ328"
> ^
> arch/m68k/kernel/setup_no.c:61:0: note: this is the location of the previous definition
> #define CPU_NAME "MC68000"
> ^
>
> Signed-off-by: Daniel Palmer <danieruru@gmail.com>
Thanks, I'll add this to the m68knommu git tree.
Regards
Greg
> arch/m68k/kernel/setup_no.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index 5b16f5d..88c27d9 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -58,17 +58,16 @@ void (*mach_halt)(void);
> void (*mach_power_off)(void);
>
> #ifdef CONFIG_M68000
> -#define CPU_NAME "MC68000"
> -#endif
> -#ifdef CONFIG_M68328
> +#if defined(CONFIG_M68328)
> #define CPU_NAME "MC68328"
> -#endif
> -#ifdef CONFIG_M68EZ328
> +#elif defined(CONFIG_M68EZ328)
> #define CPU_NAME "MC68EZ328"
> -#endif
> -#ifdef CONFIG_M68VZ328
> +#elif defined(CONFIG_M68VZ328)
> #define CPU_NAME "MC68VZ328"
> +#else
> +#define CPU_NAME "MC68000"
> #endif
> +#endif /* CONFIG_M68000 */
> #ifdef CONFIG_M68360
> #define CPU_NAME "MC68360"
> #endif
>
prev parent reply other threads:[~2014-04-08 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 5:39 [PATCH 1/2] m68k: fix some compiler warnings when building for DragonBall Daniel Palmer
2014-04-05 5:39 ` [PATCH 2/2] m68k: Only allow for one member of the DragonBall family to be selected in Kconfig. The support code for these chips doesn't currently handle support for multiple family members to be supported in a single kernel image Daniel Palmer
2014-04-05 7:42 ` [PATCH 1/2] m68k: fix some compiler warnings when building for DragonBall Geert Uytterhoeven
2014-04-05 7:46 ` Daniel Palmer
2014-04-05 8:05 ` [PATCH v2 1/2] m68k: fix a compiler warning " Daniel Palmer
2014-04-08 7:13 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343A1A9.1000102@westnet.com.au \
--to=gregungerer@westnet.com.au \
--cc=danieruru@gmail.com \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox