Re: [PATCH 0/4] m68knommu: Coldfire gpio fixes and updates.

[Greg Ungerer <gregungerer@westnet.com.au>]

Hi Steven,

On 22/05/14 09:00, sfking@fdwdc.com wrote:
> From: Steven King <sfking@fdwdc.com>
> 
> I had these queued up, forgot to send.  This fixes a heinous bug in
> mcfgpio_direction_output, adds code to enable gpio_to_irq functionality,
> removes some of the global namespace pollution in gpio.c and adds gpio support
> for the m54xx.  Tested on m5253, m5282, m5484 and m54418; compile tested only
> for the rest of the currenly supported coldfire targets.

All looks good to me. Can I add your:

  Singed-off-by: Steven King <sfking@fdwdc.com>

Thanks
Greg


> Steven King (4):
>   add to_irq function so we can map gpios to external interrupts.
>   setting the gpio data direction register to output doesn't dependent
>     upon the value to output!
>   Make everything thats not exported, static.
>   Implement gpio support for m54xx.
> 
>  arch/m68k/include/asm/m54xxsim.h   |   12 +++++++++---
>  arch/m68k/include/asm/mcfgpio.h    |   12 ++++++++----
>  arch/m68k/platform/coldfire/gpio.c |   34 +++++++++++++++++++++++-----------
>  3 files changed, 40 insertions(+), 18 deletions(-)
>