From: Greg Ungerer <gerg@uclinux.org>
To: Steven King <sfking@fdwdc.com>, linux-m68k@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH V2] m68knommu: refactor mcfgpio.h to check for defines instead of CONFIG_ symbols.
Date: Thu, 12 Jun 2014 16:35:13 +1000 [thread overview]
Message-ID: <53994A21.6060800@uclinux.org> (raw)
In-Reply-To: <201406112000.40962.sfking@fdwdc.com>
Hi Steven,
On 12/06/14 13:00, Steven King wrote:
> While the various Coldfire parts use several different methods for implementing
> GPIO, we can use the common aspects shared between the different parts as
> defined in the m5xxxsim.h files rather than relying on CONFIG_ symbols. This
> should reduce the clutter and should make it more portable for other Coldfire
> devices.
>
> V2: leave the blank lines seperating the sections in the headers.
>
> Signed-off-by: Steven King <sfking@fdwdc.com>
> ---
> [snip]
> --- a/arch/m68k/include/asm/m5272sim.h
> +++ b/arch/m68k/include/asm/m5272sim.h
> @@ -135,6 +135,7 @@
> #define MCFGPIO_PIN_MAX 48
> #define MCFGPIO_IRQ_MAX -1
> #define MCFGPIO_IRQ_VECBASE -1
> +#define MCFGPIO_PORTSIZE 16
>
> /****************************************************************************/
> #endif /* m5272sim_h */
> diff --git a/arch/m68k/include/asm/m527xsim.h b/arch/m68k/include/asm/m527xsim.h
> index 1bebbe7..86be5b9 100644
> --- a/arch/m68k/include/asm/m527xsim.h
> +++ b/arch/m68k/include/asm/m527xsim.h
> @@ -193,7 +193,7 @@
> #define MCFGPIO_PIN_MAX 100
> #define MCFGPIO_IRQ_MAX 8
> #define MCFGPIO_IRQ_VECBASE MCFINT_VECBASE
> -
> +#define MCFGPIO_PORTSIZE 8
> /*
Can you leave the blank line in here?
> [snip]
> diff --git a/arch/m68k/include/asm/m54xxsim.h b/arch/m68k/include/asm/m54xxsim.h
> index a5fbd17..3f1ecfa 100644
> --- a/arch/m68k/include/asm/m54xxsim.h
> +++ b/arch/m68k/include/asm/m54xxsim.h
> @@ -64,7 +64,7 @@
> #define MCFGPIO_PIN_MAX 136 /* 128 gpio + 8 eport */
> #define MCFGPIO_IRQ_MAX 8
> #define MCFGPIO_IRQ_VECBASE MCFINT_VECBASE
> -
> +#define MCFGPIO_PORTSIZE 8
> /*
And here too...
Regards
Greg
prev parent reply other threads:[~2014-06-12 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 2:05 [RFC/PATCH] m68knommu: refactor mcfgpio.h to check for defines instead of CONFIG_ symbols Steven King
2014-06-02 6:47 ` Greg Ungerer
2014-06-12 3:00 ` [PATCH V2] " Steven King
2014-06-12 6:35 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53994A21.6060800@uclinux.org \
--to=gerg@uclinux.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sfking@fdwdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox