From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Christoph Hellwig <hch@infradead.org>,
Michael Schmitz <schmitz@debian.org>,
Sam Creasey <sammy@sammy.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: converting the NCR5380 drivers away from scsi_register
Date: Fri, 01 Aug 2014 20:15:20 +1200 [thread overview]
Message-ID: <53DB4C98.8020907@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1408011307120.6796@nippy.intranet>
Hi Finn,
>> atari_scsi is only used on TT and Falcon Atari variants. 'Testing' for
>> hardware presence is just checking bits from a bitmap populated at
>> arch_init time, that can easily be moved into a platform device setup,
>> much like I already do for the network drivers. Does that answer your
>> question?
>>
>
> Yes. I'll convert {atari,mac,sun3}_scsi to platform devices and
> scsi_host_alloc/scsi_add_host.
>
Thanks, much appreciated. I can supply the platform device setup in
arch/m68k/atari/config.c once you have decided what kind of resources or
platform data will be needed.
If you rather want to do this - either use the ATARIHW_PRESENT() macros
to test for ST_SCSI (Falcon, interrupt no. IRQ_MFP_FSCSI) or TT_SCSI
(TT, interrupt no. IRQ_TT_MFP_SCSI). Or else, replicate the logic from
config_atari() - the SCSI chip directly mapped only in the TT integration,
the Falcon needs to access SCSI registers through the ST-DMA chip, and
needs the weird ST-DMA locking scheme plus a few other quirks.
Looking at atari_scsi.c - the code is full of IS_A_TT() macros and other
Atari specfic macros that could be replaced by testing bits in a feature
map. One bit (TT or Falcon style SCSI integration) rather - that still
leaves the register access functions for TT and Falcon to sort out. Do
you plan to do all that in one go? Might need another platform device
for the ST-DMA as well ...
Cheers,
Michael
next prev parent reply other threads:[~2014-08-01 8:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 14:18 converting the NCR5380 drivers away from scsi_register Christoph Hellwig
2014-06-17 8:20 ` Finn Thain
2014-06-17 8:38 ` Geert Uytterhoeven
2014-07-30 8:32 ` Finn Thain
2014-07-31 5:31 ` Michael Schmitz
2014-08-01 3:13 ` Finn Thain
2014-08-01 8:15 ` Michael Schmitz [this message]
2014-08-02 1:27 ` Finn Thain
2014-08-02 8:51 ` Michael Schmitz
2014-08-03 3:43 ` Finn Thain
2014-08-03 9:07 ` Michael Schmitz
2014-08-04 3:28 ` Finn Thain
2014-08-05 9:06 ` Michael Schmitz
2014-08-06 1:25 ` Sun3 SCSI DMA, was " Finn Thain
2014-08-06 14:42 ` Sam Creasey
2014-08-08 8:46 ` Michael Schmitz
2014-08-11 15:10 ` Sam Creasey
2014-08-13 5:29 ` Finn Thain
2014-08-13 9:14 ` Michael Schmitz
2014-08-14 1:43 ` Finn Thain
2014-08-14 8:57 ` Michael Schmitz
2014-08-15 1:46 ` Finn Thain
2014-08-15 1:51 ` Michael Schmitz
2014-08-15 2:09 ` Finn Thain
2014-08-15 3:03 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB4C98.8020907@gmail.com \
--to=schmitzmic@gmail.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sammy@sammy.net \
--cc=schmitz@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox