public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] USB: isp116x: Fix EtherNAT if !CONFIG_ATARI_ROM_ISA
Date: Tue, 30 Sep 2014 01:08:47 +1300	[thread overview]
Message-ID: <54294BCF.4070304@gmail.com> (raw)
In-Reply-To: <CAMuHMdWNQvB9QfidZBnHZznF-UH3Sgsr79YdhkW_H-W9P5Ni8A@mail.gmail.com>

HI Geert,
> On Sun, Sep 14, 2014 at 11:39 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>   
>> Commit eece8a651c96a2a3 ("USB: isp116x: isa_rom_*() calls should depend
>> on CONFIG_ATARI_ROM_ISA") broke USB on EtherNAT if CONFIG_ATARI_ROM_ISA
>> is not set, as USB on EtherNAT requires byte-swapped I/O accessors.
>>
>> Add a separate #elif section for Atari without ROM port ISA to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> To be folded into "m68k/atari: USB - add ISP1160 USB host controller
>> support"
>>     
>
> Applied to master, folded on m68k-queue.
>   

Thanks, I'll get the EtherNAT driver tested in a month ot two hopefully, 
so this can finally be all merged upstream.

Cheers,

    Michael
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>   

      reply	other threads:[~2014-09-29 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  9:39 [PATCH] USB: isp116x: Fix EtherNAT if !CONFIG_ATARI_ROM_ISA Geert Uytterhoeven
2014-09-28  9:39 ` Geert Uytterhoeven
2014-09-29 12:08   ` Michael Schmitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54294BCF.4070304@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox