Re: [PATCH 07/29] ncr5380: Cleanup TAG_NEXT and TAG_NONE macros

Hannes Reinecke
2014-10-06T09:19:25Z

On 10/02/2014 08:56 AM, Finn Thain wrote:
> Both atari_NCR5380.c and sun3_NCR5380.c core drivers #undef TAG_NONE and then
> redefine it. But the original definition is unused because NCR5380.c lacks
> support for tagged queueing. So just define it once.
>
> The TAG_NEXT macro only appears in the arguments to NCR5380_select() calls.
> But that routine doesn't use its tag argument as the tag was already assigned
> in NCR5380_main(). So remove the unused argument and the macro.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Why not use 'SCSI_NO_TAG' from include/scsi/scsi_tcq.h ?

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)