Re: [PATCH 07/29] ncr5380: Cleanup TAG_NEXT and TAG_NONE macros

Geert Uytterhoeven
2014-10-03T08:09:35Z

On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> --- linux.orig/drivers/scsi/NCR5380.h 2014-10-02 16:55:55.000000000 +1000
> +++ linux/drivers/scsi/NCR5380.h 2014-10-02 16:55:57.000000000 +1000
> @@ -224,14 +224,11 @@
> #define DISCONNECT_LONG 2
>
> /*
> - * These are "special" values for the tag parameter passed to NCR5380_select.
> + * "Special" value for the (unsigned char) command tag, to indicate
> + * I_T_L nexus instead of I_T_L_Q.
> */

I guess the above comment can just be removed instead of changed, as
the I_T_L nexus definitions below are removed?

> -#define TAG_NEXT -1 /* Use next free tag */
> -#define TAG_NONE -2 /*
> - * Establish I_T_L nexus instead of I_T_L_Q
> - * even on SCSI-II devices.
> - */
> +#define TAG_NONE 0xff
>
> /*
> * These are "special" values for the irq and dma_channel fields of the
> @@ -323,7 +320,7 @@ static irqreturn_t NCR5380_intr(int irq,

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds