Re: [PATCH 23/29] atari_scsi: Convert to platform device

Michael Schmitz
2014-10-26T07:37:12Z

Finn,
> On Mon, 20 Oct 2014, Michael Schmitz wrote:
>
>
>> Hi Finn,
>>
>> not certain it is related to this exact patch - the driver crashes
>> pretty much on the spot when selecting the first target on the bus.
>>
>
> If it isn't that exact patch then it will probably be one of the other
> atari_scsi patches. Most of the other relevant stuff was covered by my own
> testing.
>
> Anyway, thanks for testing and for sending the backtrace. I'll figure out
> what went wrong and fix it before I send a new patch set.
>
>

Turns out I missed a reject in patch 29 of the series (hunk #4) which
caused a local_irq_save(flags) to go AWOL. Both commenting out the
resulting lone local_irq_restore(flags), as well as fixing the reject
properly makes the driver behave as it should.

No locking races, and no more warnings about bytes stuck in the DMA
fifo. We might be on to a winner here :-)

Cheers,

Michael