Re: [PATCH 23/29] atari_scsi: Convert to platform device

Finn Thain
2014-10-27T00:16:25Z

On Sun, 26 Oct 2014, Michael Schmitz wrote:

> > On Mon, 20 Oct 2014, Michael Schmitz wrote:
> >
> > > not certain it is related to this exact patch - the driver crashes
> > > pretty much on the spot when selecting the first target on the bus.
> > >
> > ...
>
> Turns out I missed a reject in patch 29 of the series (hunk #4) which
> caused a local_irq_save(flags) to go AWOL. Both commenting out the
> resulting lone local_irq_restore(flags), as well as fixing the reject
> properly makes the driver behave as it should.
>
> No locking races, and no more warnings about bytes stuck in the DMA
> fifo. We might be on to a winner here :-)

That's good to hear. Thanks for testing v1. I'll send v2 when I'm done
testing it.

--