Re: [PATCH 28/29] atari_NCR5380: Refactor Falcon special cases

Finn Thain
2014-10-06T11:35:26Z

On Mon, 6 Oct 2014, Hannes Reinecke wrote:

> On 10/02/2014 08:56 AM, Finn Thain wrote:
> > Make the atari_NCR5380.c core driver usable by sun3_scsi, mac_scsi and
> > others by moving some of the Falcon-specific code out of the core
> > driver: !IS_A_TT, atari_read_overruns and falcon_dont_release. Replace
> > these with hostdata variables and flags. FLAG_CHECK_LAST_BYTE_SENT is
> > unused in atari_NCR5380.c so don't set it.
> >
> Hmm. Shouldn't there be some more patches for sun3_scsi and mac_scsi to
> actually make use of this?

Yes, I think you are right, some of those patches should be included.

I've done some testing of mac_scsi and dmx3191d using the atari_NCR5380.c
core driver but this isn't working adequately yet. It's not yet a proof of
concept.

To convert sun3_scsi to use the atari_NCR5380 core driver is easier.

If I had atari and sun3 hardware to test on, everything would be done in
one patch set and I could test the end result rather than asking others to
test it in stages on the appropriate hardware.

Anyway, I will include more patches when I re-submit: not just the
sun3_NCR5380.c removal (which is ugly but hopefully Sam can simplify it)
but also some more work on atari_NCR5380.c (to minimise testing effort).

>
> I'd _love_ to get rid of all of this NCR5380 code duplication ...

My reading is that if mac_scsi can work with atari_NCR5380 then the same
is very likely true for the ARM drivers (oak, cumana_1) and also dmx3191d.

To merge atari_NCR5380.c with NCR5380.c would be much more difficult. If
someone who has the hardware were to take an interest in the remaining
drivers (just the ISA card drivers, dtc, pas16, g_NCR5380, t128), perhaps
it would be feasible.

--

>
> Cheers,
>
> Hannes
>