Re: [PATCH RFC] m68k: skip kernel premption if interrupts were disabled

Geert Uytterhoeven
2024-03-27T08:23:03Z

Hi Michael,

On Tue, Mar 26, 2024 at 8:59 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> thanks - I'm pretty sure tried that early on but botched it by excessive
> locking (i.e., keeping preemption disabled when calling
> get_zeroed_page()!).
>
> So I don't think you do use too much locking here.
>
> I'm running stress tests for a while now, without any trouble so far.
> Need to add a few other stressors back in, and repeat all that on a
> slower ARAnyM instance but I'm quite confident you found the solution.
>
> Geert: with this data race fixed, it does appear my RFC patch is no
> longer needed. Finn or I probably ought to prepare a new RFC patch to go
> on top of your preemption patch. There is no commit ID to use in a
> Fixes: tag for that one, correct?

As my preemption patch was not applied to any tree yet, I'll just
fold in any fixes. I think this does deserve Co-developed-by tags,
so please make sure to include your SoB in any fixes.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds