From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v4 20/30] PCI/sparc: Use pci_scan_root_bridge() for simplicity Date: Tue, 3 Mar 2015 16:49:46 +0800 Message-ID: <54F575AA.6050409@huawei.com> References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-21-git-send-email-wangyijing@huawei.com> <20150303031059.GJ11978@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150303031059.GJ11978@google.com> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven , sparclinux@vger.kernel.org >> - pci_of_scan_bus(pbm, node, bus); >> - pci_bus_add_devices(bus); >> - pci_bus_register_of_sysfs(bus); >> + pci_bus_add_devices(host->bus); >> + pci_bus_register_of_sysfs(host->bus); >> >> - pci_claim_bus_resources(bus); >> + pci_claim_bus_resources(host->bus); > > Isn't this a case where pci_claim_bus_resources() should be done before > pci_bus_add_devices()? You didn't introduce this problem, but since you're > fixing similar issues, seems like we should fix this one, too. In a patch > of its own, of course. OK, will fix in a another patch. > >> >> - return bus; >> + return host->bus; >> } >> >> void pcibios_fixup_bus(struct pci_bus *pbus) >> -- >> 1.7.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > . > -- Thanks! Yijing