From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro Date: Tue, 22 Dec 2015 08:34:09 +0100 Message-ID: <5678FCF1.10305@suse.de> References: <20151222011737.980475848@telegraphics.com.au> <20151222011748.365505398@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:43070 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbLVHeL (ORCPT ); Tue, 22 Dec 2015 02:34:11 -0500 In-Reply-To: <20151222011748.365505398@telegraphics.com.au> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" On 12/22/2015 02:18 AM, Finn Thain wrote: > Configuring core drivers using macros like this one prevents re-unify= ing > the core driver forks, and prevents implementing the core driver as a > library or a platform driver. > > The UNSAFE macro in particular is a poor workaround for the problem o= f > interrupt latency. Releasing the locks complicates things because the= n we > would have to handle the possibility of EH handler invocation during = a > PDMA transfer. > > The comments say that instead of using this macro, "you're going to b= e > better off twiddling with transfersize". I agree. Remove this stuff. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)