From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=7lc4=CG=vger.kernel.org=linux-m68k-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8D325C433E6
	for <linux-m68k@archiver.kernel.org>; Fri, 28 Aug 2020 00:01:55 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 694C52080C
	for <linux-m68k@archiver.kernel.org>; Fri, 28 Aug 2020 00:01:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727926AbgH1ABz (ORCPT <rfc822;linux-m68k@archiver.kernel.org>);
        Thu, 27 Aug 2020 20:01:55 -0400
Received: from smtprelay0140.hostedemail.com ([216.40.44.140]:59830 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1726972AbgH1ABz (ORCPT
        <rfc822;linux-m68k@lists.linux-m68k.org>);
        Thu, 27 Aug 2020 20:01:55 -0400
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay04.hostedemail.com (Postfix) with ESMTP id E414D1800C860;
        Fri, 28 Aug 2020 00:01:53 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: badge21_0410db127071
X-Filterd-Recvd-Size: 1992
Received: from XPS-9350.home (unknown [47.151.133.149])
        (Authenticated sender: joe@perches.com)
        by omf14.hostedemail.com (Postfix) with ESMTPA;
        Fri, 28 Aug 2020 00:01:51 +0000 (UTC)
Message-ID: <5682daf68b94be288c05f859942ce06deec2b022.camel@perches.com>
Subject: Re: [PATCH 17/19] z2ram: reindent
From:   Joe Perches <joe@perches.com>
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Denis Efremov <efremov@linux.com>,
        "David S. Miller" <davem@davemloft.net>,
        Song Liu <song@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Date:   Thu, 27 Aug 2020 17:01:50 -0700
In-Reply-To: <alpine.LNX.2.23.453.2008280859300.10@nippy.intranet>
References: <8570915f668159f93ba2eb845a3bbc05f8ee3a99.camel@perches.com>
         <EF673A30-F88D-4E4E-8A2B-E942153830AC@physik.fu-berlin.de>
         <b88538f92386f41b938c502ae2daec5800a85dcf.camel@perches.com>
         <alpine.LNX.2.23.453.2008280859300.10@nippy.intranet>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-m68k-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-m68k.vger.kernel.org>
X-Mailing-List: linux-m68k@vger.kernel.org

On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote:
> > @@ -109,34 +111,28 @@ static void get_z2ram(void)
> ...
> >  	}
> > -
> > -	return;
> >  }
> >  
> 
> It would be good to have a semantic patch for that change.
> 
> >  
> > -		if (z2ram_map[z2ram_size] == 0) {
> > +		if (z2ram_map[z2ram_size] == 0)
> >  			break;
> > -		}
> >  
> 
> And that one.
> 
> Reason being, a semantic patch only has to be debugged once, whereas 
> manual churn has to be done correctly over and over again.

checkpatch already does this.