From: Greg Ungerer <gerg@uclinux.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] m68knommu: fix FEC platform device registration when driver is modular
Date: Mon, 11 Jan 2016 22:29:36 +1000 [thread overview]
Message-ID: <5693A030.4090402@uclinux.org> (raw)
In-Reply-To: <CAMuHMdXarYfyvy3AHW+=Bmx2NQZigB+a8hjE5J8ikr_R+f8OGQ@mail.gmail.com>
On 11/01/16 17:50, Geert Uytterhoeven wrote:
> On Mon, Jan 11, 2016 at 2:21 AM, Greg Ungerer <gerg@uclinux.org> wrote:
>> The FEC (Fast Ethernet Crontroller) module on many ColdFire parts can
>> be compiled into the kernel, or as a module. Therefore the platform device
>> support for it is required whenever the driver is enabled - not just when
>> built into the kernel. Use IS_ENABLED(CONFIG_FEC) instead of a conditional
>> check on only the driver being built into the kernel.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks Geert!
Regards
Greg
prev parent reply other threads:[~2016-01-11 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 1:21 [PATCH] m68knommu: fix FEC platform device registration when driver is modular Greg Ungerer
2016-01-11 7:50 ` Geert Uytterhoeven
2016-01-11 12:29 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693A030.4090402@uclinux.org \
--to=gerg@uclinux.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox