From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Date: Mon, 14 Mar 2016 08:34:55 +0100 Message-ID: <56E6699F.2050401@suse.de> References: <20160314042700.596192247@telegraphics.com.au> <20160314042702.716014118@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:55646 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbcCNHe5 (ORCPT ); Mon, 14 Mar 2016 03:34:57 -0400 In-Reply-To: <20160314042702.716014118@telegraphics.com.au> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org Cc: Ondrej Zary , Sam Creasey On 03/14/2016 05:27 AM, Finn Thain wrote: > Those wrapper drivers which use DMA define the REAL_DMA macro and > those which use pseudo DMA define PSEUDO_DMA. These macros need to be > removed for a number of reasons, not least of which is to have driver= s > share more code. >=20 > Redefine the PDMA send and receive hooks as DMA setup hooks, so that = the > DMA code can be shared by all 5380 wrapper drivers. This will help to > reunify the forked core driver. >=20 > Signed-off-by: Finn Thain >=20 > --- > drivers/scsi/NCR5380.c | 10 ++-------- > drivers/scsi/arm/cumana_1.c | 10 ++++++---- > drivers/scsi/arm/oak.c | 10 ++++++---- > drivers/scsi/dmx3191d.c | 4 ++-- > drivers/scsi/dtc.c | 6 ++++-- > drivers/scsi/dtc.h | 2 ++ > drivers/scsi/g_NCR5380.c | 10 ++++++---- > drivers/scsi/g_NCR5380.h | 4 ++-- > drivers/scsi/mac_scsi.c | 5 ++--- > drivers/scsi/pas16.c | 14 ++++++++------ > drivers/scsi/pas16.h | 2 ++ > drivers/scsi/t128.c | 12 ++++++------ > drivers/scsi/t128.h | 2 ++ > 13 files changed, 50 insertions(+), 41 deletions(-) >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg)