From: Greg Ungerer <gerg@linux-m68k.org>
To: angelo@kernel-space.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH v2] m68k: coldfire: fix irq ranges
Date: Fri, 23 Apr 2021 08:31:10 +1000 [thread overview]
Message-ID: <61f697da-e42c-4b38-8260-334607fb29f7@linux-m68k.org> (raw)
Hi Angelo,
Sorry for the slow pick up of this. Some email problems caused me
to not get the original emails (saw this in the archives).
Applied to m68knommu git tree, for-next branch.
Regards
Greg
> Working on flexcan0, there was no way to have irq 128 working.
> Fix irq 128 and 196 setup.
>
> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
> ---
> Change for v2:
> line 85, fix >= into >
> ---
> arch/m68k/coldfire/intc-simr.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/m68k/coldfire/intc-simr.c b/arch/m68k/coldfire/intc-simr.c
> index 15c4b7a6e38f..f7c2c41b3156 100644
> --- a/arch/m68k/coldfire/intc-simr.c
> +++ b/arch/m68k/coldfire/intc-simr.c
> @@ -68,9 +68,9 @@ static void intc_irq_mask(struct irq_data *d)
> {
> unsigned int irq = d->irq - MCFINT_VECBASE;
>
> - if (MCFINTC2_SIMR && (irq > 128))
> + if (MCFINTC2_SIMR && (irq > 127))
> __raw_writeb(irq - 128, MCFINTC2_SIMR);
> - else if (MCFINTC1_SIMR && (irq > 64))
> + else if (MCFINTC1_SIMR && (irq > 63))
> __raw_writeb(irq - 64, MCFINTC1_SIMR);
> else
> __raw_writeb(irq, MCFINTC0_SIMR);
> @@ -80,9 +80,9 @@ static void intc_irq_unmask(struct irq_data *d)
> {
> unsigned int irq = d->irq - MCFINT_VECBASE;
>
> - if (MCFINTC2_CIMR && (irq > 128))
> + if (MCFINTC2_CIMR && (irq > 127))
> __raw_writeb(irq - 128, MCFINTC2_CIMR);
> - else if (MCFINTC1_CIMR && (irq > 64))
> + else if (MCFINTC1_CIMR && (irq > 63))
> __raw_writeb(irq - 64, MCFINTC1_CIMR);
> else
> __raw_writeb(irq, MCFINTC0_CIMR);
> @@ -115,9 +115,9 @@ static unsigned int intc_irq_startup(struct irq_data *d)
> }
>
> irq -= MCFINT_VECBASE;
> - if (MCFINTC2_ICR0 && (irq > 128))
> + if (MCFINTC2_ICR0 && (irq > 127))
> __raw_writeb(5, MCFINTC2_ICR0 + irq - 128);
> - else if (MCFINTC1_ICR0 && (irq > 64))
> + else if (MCFINTC1_ICR0 && (irq > 63))
> __raw_writeb(5, MCFINTC1_ICR0 + irq - 64);
> else
> __raw_writeb(5, MCFINTC0_ICR0 + irq);
> --
> 2.31.0
next reply other threads:[~2021-04-22 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 22:31 Greg Ungerer [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-08 21:37 [PATCH v2] m68k: coldfire: fix irq ranges Angelo Dureghello
2021-04-12 7:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f697da-e42c-4b38-8260-334607fb29f7@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=angelo@kernel-space.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox