From: Michael Schmitz <schmitzmic@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
geert@linux-m68k.org, linux-m68k@vger.kernel.org
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block - ataflop.c: fix breakage introduced at blk-mq refactoring
Date: Wed, 20 Oct 2021 10:30:09 +1300 [thread overview]
Message-ID: <658a78d1-942c-3099-eaac-91afbbddc31c@gmail.com> (raw)
In-Reply-To: <163464555754.595860.5260761740824485566.b4-ty@kernel.dk>
Thanks Jens,
I'll pore over the code some more to see if there are any other problems...
Cheers,
Michael
On 20/10/21 01:12, Jens Axboe wrote:
> On Tue, 19 Oct 2021 19:13:21 +1300, Michael Schmitz wrote:
>> Refactoring of the Atari floppy driver when converting to blk-mq
>> has broken the state machine in not-so-subtle ways:
>>
>> finish_fdc() must be called when operations on the floppy device
>> have completed. This is crucial in order to relase the ST-DMA
>> lock, which protects against concurrent access to the ST-DMA
>> controller by other drivers (some DMA related, most just related
>> to device register access - broken beyond compare, I know).
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] block - ataflop.c: fix breakage introduced at blk-mq refactoring
> commit: 86d46fdaa12ae5befc16b8d73fc85a3ca0399ea6
>
> Best regards,
>
prev parent reply other threads:[~2021-10-19 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 6:13 [PATCH v2] block - ataflop.c: fix breakage introduced at blk-mq refactoring Michael Schmitz
2021-10-19 12:12 ` Jens Axboe
2021-10-19 21:30 ` Michael Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658a78d1-942c-3099-eaac-91afbbddc31c@gmail.com \
--to=schmitzmic@gmail.com \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox