Re: [PATCH v3 2/3] hwmon/ltc2990: Generalise DT to fwnode support

Max Staudt
2019-08-15T22:19:42Z

On 08/15/2019 02:58 PM, Max Staudt wrote:
> - if (of_node) {
> - ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
> - data->mode, 2);
> + if (i2c->dev.of_node || i2c->dev.fwnode) {

One more idea, would it be better here to do the following?

if (device_property_present(i2c->dev, "lltc,meas-mode")) {
ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
data->mode, 2);
}

I'm happy to prepare a patch if you wish to have this in - just let me know whether it should be on top of the last one, or instead of it.

Thanks,
Max