public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gregungerer@westnet.com.au>
To: Angelo Dureghello <angelo@sysam.it>, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] m68k: add Sysam stmark2 open board support
Date: Mon, 4 Dec 2017 14:22:22 +1000	[thread overview]
Message-ID: <6f9ca6ab-1e44-8a41-e27d-07e2af297346@westnet.com.au> (raw)
In-Reply-To: <20171012224251.1015-1-angelo@sysam.it>

Hi Angelo,

On 13/10/17 08:42, Angelo Dureghello wrote:
> Add support for Sysam stmark2 board, an open hardware embedded
> Linux board, see http://sysam.it/cff_stmark2.html for any info.
> 
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
[snip]
> diff --git a/arch/m68k/configs/stmark2_defconfig b/arch/m68k/configs/stmark2_defconfig
> new file mode 100644
> index 000000000000..55e55dbc2fb6
> --- /dev/null
> +++ b/arch/m68k/configs/stmark2_defconfig
> @@ -0,0 +1,92 @@
> +CONFIG_LOCALVERSION="stmark2-001"
> +CONFIG_DEFAULT_HOSTNAME="stmark2"
> +CONFIG_SYSVIPC=y
> +# CONFIG_FHANDLE is not set
> +CONFIG_LOG_BUF_SHIFT=14
> +CONFIG_NAMESPACES=y
> +CONFIG_BLK_DEV_INITRD=y
> +CONFIG_INITRAMFS_SOURCE="../uClinux-dist/romfs"

This causes a stand alone kernel defconfig build of stmark2 to fail with:

...
  CC      init/calibrate.o
  CC      init/init_task.o
  AR      init/built-in.o
  HOSTCC  usr/gen_init_cpio
  ./scripts/gen_initramfs_list.sh: Cannot open '../uClinux-dist/romfs'
make[1]: *** [usr/initramfs_data.cpio.gz] Error 1
make: *** [usr] Error 2

Obviously in a stand alone build you cannot rely on any directory
paths outside of the kernel tree.

The simple solution is just to remove this CONFIG_INITRAMFS_SOURCE
line - and that results in complete build. Of course it won't
work on your target as expected though.

Other ColdFire defconfigs don't use an init ramfs, instead using
a local ram based MTD partition. 

Do you want to come up with a patch to fix this?
Otherwise I will create a patch that just removes that one line.

Regards
Greg

  parent reply	other threads:[~2017-12-04  4:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 22:42 [PATCH] m68k: add Sysam stmark2 open board support Angelo Dureghello
2017-10-13  6:56 ` Greg Ungerer
2017-10-13 21:59   ` Angelo Dureghello
2017-12-04  4:22 ` Greg Ungerer [this message]
2017-12-04  8:35   ` Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f9ca6ab-1e44-8a41-e27d-07e2af297346@westnet.com.au \
    --to=gregungerer@westnet.com.au \
    --cc=angelo@sysam.it \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox