From: sfjro@users.sourceforge.net
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Thorsten Glaser <tg@mirbsd.de>,
aufs-users@lists.sourceforge.net,
Debian kernel team <debian-kernel@lists.debian.org>,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt
Date: Mon, 02 Jan 2012 13:01:50 +0900 [thread overview]
Message-ID: <7012.1325476910@jrobl> (raw)
In-Reply-To: <1325475600.13595.208.camel@deadeye>
Ben Hutchings:
> Why, how often do you expect to change AUFS_NAME?
I don't know.
I just don't want call myself idiot when it happens.
> I think it would be much better to put this in fs/aufs/aufs.h and make
> each of fs/aufs/*.c include that first.
Yes, that is my another option I have considered.
Also I am considering to move AUFS_NAME back into aufs_type.h.
In aufs_type.h:
(at the top)
#define AUFS_NAME ...
#if KERNEL
#define pr_fmt ...
#include sched.h
#endif
and include aufs_type.h at the top of source files.
> The comment about sparse belongs immediately before the definition of
> pr_fmt.
Yes, I am changing like this.
--- a/fs/aufs/Makefile
+++ b/fs/aufs/Makefile
@@ -8,9 +8,10 @@ endif
# cf. include/linux/kernel.h
# enable pr_debug
ccflags-y += -DDEBUG
+# sparse requires the fullpath
+ccflags-y += -imacros ${srctree}/include/linux/aufs_name.h
+ccflags-y += -include ${srctree}/include/linux/sched.h
# sparse doesn't allow spaces
-ccflags-y += -imacros linux/aufs_name.h
-ccflags-y += -include linux/sched.h
ccflags-y += -D'pr_fmt(fmt)=AUFS_NAME"\040%s:%d:%s[%d]:\040"fmt,__func__,__LINE__,current->comm,current->pid'
obj-$(CONFIG_AUFS_FS) += aufs.o
J. R. Okajima
next prev parent reply other threads:[~2012-01-02 4:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 17:06 [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt Ben Hutchings
2011-12-31 4:46 ` sfjro
2011-12-31 8:01 ` Geert Uytterhoeven
2011-12-31 16:31 ` Thorsten Glaser
2012-01-02 2:58 ` sfjro
2012-01-02 3:40 ` Ben Hutchings
2012-01-02 4:01 ` sfjro [this message]
2012-01-02 2:04 ` sfjro
2011-12-31 22:18 ` Thorsten Glaser
2011-12-31 22:31 ` Thorsten Glaser
2012-01-01 1:15 ` Thorsten Glaser
2012-01-02 6:45 ` sfjro
2012-01-02 10:31 ` Thorsten Glaser
2012-01-02 13:15 ` sfjro
2012-01-02 13:30 ` Thorsten Glaser
2012-01-02 13:53 ` sfjro
2012-01-02 16:14 ` Thorsten Glaser
2012-01-02 16:53 ` sfjro
2012-01-02 17:36 ` Thorsten Glaser
2012-01-03 5:21 ` [PATCH 0/2] aufs: headers (Re: [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt) sfjro
2012-01-03 5:21 ` [PATCH 1/2] aufs: headers 1/2, bugfix, where the pr_fmt macro definition sfjro
2012-01-03 5:21 ` [PATCH 2/2] aufs: headers 2/2, simply refined sfjro
2011-12-31 22:55 ` [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt Thorsten Glaser
2012-01-01 8:47 ` Geert Uytterhoeven
2012-01-01 14:48 ` Thorsten Glaser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7012.1325476910@jrobl \
--to=sfjro@users.sourceforge.net \
--cc=aufs-users@lists.sourceforge.net \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox