From: David Howells <dhowells@redhat.com>
To: Greg Ungerer <gerg@snapgear.com>
Cc: dhowells@redhat.com, paul.gortmaker@windriver.com, hpa@zytor.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH 13/35] Disintegrate asm/system.h for M68K [ver #2]
Date: Thu, 15 Mar 2012 20:18:33 +0000 [thread overview]
Message-ID: <7100.1331842713@redhat.com> (raw)
In-Reply-To: <4F608A15.9030609@snapgear.com>
Greg Ungerer <gerg@snapgear.com> wrote:
> This breaks compilation for m68k targets with:
>
> CC net/ipv4/ip_input.o
> In file included from
> /home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/system.h:3:0,
> from net/ipv4/ip_input.c:116:
> /home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/cmpxchg.h: In function
> ‘__xchg’:
> /home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/cmpxchg.h:33:3: error:
> implicit declaration of function ‘BUG’
>
> The old system.h included linux/kernel.h which includes asm/bug.h.
> Just including asm/bug.h here in cmpxchg.h is not enough to fix it.
> If you include linux/kernel.h though it compiles cleanly.
Which targets, btw?
David
next prev parent reply other threads:[~2012-03-15 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120312233602.13888.27659.stgit@warthog.procyon.org.uk>
2012-03-12 23:38 ` [PATCH 13/35] Disintegrate asm/system.h for M68K [ver #2] David Howells
2012-03-14 12:07 ` Greg Ungerer
2012-03-15 20:18 ` David Howells [this message]
2012-03-16 1:05 ` Greg Ungerer
2012-03-16 13:42 ` David Howells
2012-03-19 2:24 ` Greg Ungerer
2012-03-19 10:49 ` David Howells
2012-03-19 11:48 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7100.1331842713@redhat.com \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=gerg@snapgear.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox