public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: wuyonggang001@208suo.com
To: geert@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: [PATCH] m68k/q40: Fix syntax error
Date: Wed, 14 Jun 2023 14:02:15 +0800	[thread overview]
Message-ID: <74ed374c5d5ec504d3bbecef656c1b37@208suo.com> (raw)
In-Reply-To: <4c81c6406707cf2e26b43bd4c5caca3a@208suo.com>

Fix the following checkpatch error:

ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)

Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
---
  arch/m68k/q40/config.c | 18 +++++++++---------
  1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c
index c78ee709b458..79670d670ffb 100644
--- a/arch/m68k/q40/config.c
+++ b/arch/m68k/q40/config.c
@@ -148,12 +148,12 @@ static void q40_get_model(char *model)

  static unsigned int serports[] =
  {
-    0x3f8,0x2f8,0x3e8,0x2e8,0
+    0x3f8, 0x2f8, 0x3e8, 0x2e8, 0
  };

  static void __init q40_disable_irqs(void)
  {
-    unsigned i, j;
+    unsigned int i, j;

      j = 0;
      while ((i = serports[j++]))
@@ -227,12 +227,12 @@ static int q40_hwclk(int op, struct rtc_time *t)
          /* Read....  */
          Q40_RTC_CTRL |= Q40_RTC_READ;

-        t->tm_year = bcd2bin (Q40_RTC_YEAR);
-        t->tm_mon  = bcd2bin (Q40_RTC_MNTH)-1;
-        t->tm_mday = bcd2bin (Q40_RTC_DATE);
-        t->tm_hour = bcd2bin (Q40_RTC_HOUR);
-        t->tm_min  = bcd2bin (Q40_RTC_MINS);
-        t->tm_sec  = bcd2bin (Q40_RTC_SECS);
+        t->tm_year = bcd2bin(Q40_RTC_YEAR);
+        t->tm_mon  = bcd2bin(Q40_RTC_MNTH)-1;
+        t->tm_mday = bcd2bin(Q40_RTC_DATE);
+        t->tm_hour = bcd2bin(Q40_RTC_HOUR);
+        t->tm_min  = bcd2bin(Q40_RTC_MINS);
+        t->tm_sec  = bcd2bin(Q40_RTC_SECS);

          Q40_RTC_CTRL &= ~(Q40_RTC_READ);

@@ -270,7 +270,7 @@ static int q40_set_rtc_pll(struct rtc_pll_info *pll)
      if (!pll->pll_ctrl) {
          /* the docs are a bit unclear so I am doublesetting */
          /* RTC_WRITE here ... */
-        int tmp = (pll->pll_value & 31) | (pll->pll_value<0 ? 32 : 0) |
+        int tmp = (pll->pll_value & 31) | (pll->pll_value < 0 ? 32 : 0) 
|
                Q40_RTC_WRITE;
          Q40_RTC_CTRL |= Q40_RTC_WRITE;
          Q40_RTC_CTRL = tmp;

       reply	other threads:[~2023-06-14  6:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230614032446.8391-1-zhanglibing@cdjrlc.com>
     [not found] ` <4c81c6406707cf2e26b43bd4c5caca3a@208suo.com>
2023-06-14  6:02   ` wuyonggang001 [this message]
2023-06-14  9:34     ` [PATCH] m68k/q40: Fix syntax error Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74ed374c5d5ec504d3bbecef656c1b37@208suo.com \
    --to=wuyonggang001@208suo.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox