From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFB0C433EF for ; Mon, 27 Sep 2021 23:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 908E0611C2 for ; Mon, 27 Sep 2021 23:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238057AbhI0XZk (ORCPT ); Mon, 27 Sep 2021 19:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238115AbhI0XZk (ORCPT ); Mon, 27 Sep 2021 19:25:40 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA08BC061604 for ; Mon, 27 Sep 2021 16:24:01 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id b78so19656169iof.2 for ; Mon, 27 Sep 2021 16:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aiFGagUTxQBnltkSEFIoIU5oY0RjA6yVWSQ2liMMneI=; b=j4l4cerZxmvRBFo9+l9BQYL6AkzAopJsl20GWDSIrISjgLNhwhyUQDgcFLI87OvTcL t/He9yZhqI/cPodGu+OkbgGmH1S7L95w9IwBPy2eDb5ZhrO4OA22DQ6orSLthPUp8xVZ oIIr58M8MAbD2pjlXaHNHESM9fKnM1zfg80Mb2N1pp9d9BpGhpxkwS7as7y454k+B0ye LufmIqZDO3GmPh+zxBgitFrPpt5gouRgTIBta571rDslFpm75wmx5PtMFvZKfisPb48N 6e4Pw3KgnWYPremFqKZ5Zf2mk39T9srpZap80F9Oudy/lbsB3AgEF4sONU54MRun0xf/ Kvkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aiFGagUTxQBnltkSEFIoIU5oY0RjA6yVWSQ2liMMneI=; b=s7AswN6bPQ2A53UHmxXBJpY2k3pJfYgCHXEBeU6/EGOcT8ODaRfP+f4WDHB7lUTbe0 bHRowocCNTuGqTnTis+OnToqYn5Ti8JEX+Z8Q21oSM4ovXj/D8asThCvcpwnYwlGX9Lm cBW37Q7TwiTHnsTkpVLP+vKkT4arWzmcf5zzNwuEIjlvxEmXen1zByos3b+loCW2kiwZ 7t2WASkpI5OAIHAXIxNkklxxUrBien9bRoN/+IWHsGtCVoIBoTr8M3q1mCf4R2HUYYNq oWDOUsMnVDAzhc4P/vJ8EPaA64EW0La2fsFVZWJa0NChUtUdJYtfxLhqvNa8e6oY/t0I ibEg== X-Gm-Message-State: AOAM530IspA9x+++o3OAoJ54Bz3jMI7jf1G3gF/H0urN7RWB7rD44Pov SmvUSLZ6Pu91MwGIyMK0g3JSNQ== X-Google-Smtp-Source: ABdhPJzcHoH9jP9w7ZB7Bz7huhMzmKrPerS4qwZbTDMWfRTFVmKbhCBMUPsYmvpBiIoTu14VNW/P4w== X-Received: by 2002:a6b:6f0a:: with SMTP id k10mr1611488ioc.101.1632785041193; Mon, 27 Sep 2021 16:24:01 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id o7sm10361931ilm.9.2021.09.27.16.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 16:24:00 -0700 (PDT) Subject: Re: [PATCH v2 06/15] xtensa/platforms/iss/simdisk: add error handling support for add_disk() To: Max Filippov , Luis Chamberlain Cc: justin@coraid.com, Geert Uytterhoeven , Ulf Hansson , hare@suse.de, Tejun Heo , philipp.reisner@linbit.com, lars.ellenberg@linbit.com, Jeff Dike , Richard Weinberger , Anton Ivanov , johannes.berg@intel.com, chris.obbard@collabora.com, krisman@collabora.com, zhuyifei1999@gmail.com, thehajime@gmail.com, Chris Zankel , tim@cyberelk.net, "open list:TENSILICA XTENSA PORT (xtensa)" , linux-um@lists.infradead.org, "open list:M68K ARCHITECTURE" , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, LKML References: <20210927220110.1066271-1-mcgrof@kernel.org> <20210927220110.1066271-7-mcgrof@kernel.org> From: Jens Axboe Message-ID: <7889116c-c01a-a041-89f3-4390b16c6ac0@kernel.dk> Date: Mon, 27 Sep 2021 17:24:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 9/27/21 4:50 PM, Max Filippov wrote: > On Mon, Sep 27, 2021 at 3:01 PM Luis Chamberlain wrote: >> >> We never checked for errors on add_disk() as this function >> returned void. Now that this is fixed, use the shiny new >> error handling. >> >> Signed-off-by: Luis Chamberlain >> --- >> arch/xtensa/platforms/iss/simdisk.c | 13 +++++++++++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) > > Acked-by: Max Filippov Applied, thanks. -- Jens Axboe