Re: [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data

Finn Thain
2023-08-21T11:07:56Z

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On Mon, 21 Aug 2023, Geert Uytterhoeven wrote:

> On Sat, Aug 19, 2023 at 1:53 AM Finn Thain <fthain@linux-m68k.org> wrote:
> > On Fri, 18 Aug 2023, Geert Uytterhoeven wrote:
> > > Of course 0 also works, but causes ".0" to be appended to the platform
> > > device's name, visible in e.g. /sys/bus/platform/devices/.
> >
> > That seems desirable to me.
>
> Why would it be desirable?
> IMHO this is an unneeded change which is visible in userspace.
>

Only so what's visible in userspace would be consistent across atari and
q40 (and anything else that happens to instantiate the device in future).

Basically, I don't really understand why id -1 is better than id 0. I've
searched Documentation/device-tree and I still don't understand why a
singleton would need a special bus id.