Re: [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data

Geert Uytterhoeven
2023-08-18T14:34:09Z

Hi Michael,

On Thu, Aug 17, 2023 at 11:28 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> On 18/08/23 07:21, Michael Schmitz wrote:
> >>>> + priv->swap_mask = pata_falcon_swap_mask;
> >> priv->swap_mask = pata_falcon_swap_mask >> (2 * pdev->id);
> >
> > The Atari platform driver data is registered with pdev->id=-1. That'll
> > break here.
>
> Confirmed.

Oops.

> > (Not sure why that choice of pdev->id, and whether it can be changed
> > to 0 easily)
> Seems to work OK with ID set to 0, so I'll simplify that as you suggest.

-1 is used to indicate there can only ever be a single instance.
Of course 0 also works, but causes ".0" to be appended to the platform
device's name, visible in e.g. /sys/bus/platform/devices/.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds