Re: [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data

Finn Thain
2023-08-21T23:18:47Z

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

On Tue, 22 Aug 2023, Michael Schmitz wrote:

> CC Adrian for comment...
>

My comments in the messages quoted below should not be interpreted as an
objection to the patches Michael submitted.

I've already done too much bikeshedding there and while it's always
tempting to do more I will desist.

This was just a look askance at the design of the driver model. So it's
really only of academic interest.

> Does anything in the Debian installer rely on a specific device name suffix in
> /sys/bus/platform/devices/ ?
>
> On Atari, atari-falcon-ide does not have a suffix, but on Q40, it would get
> suffix .0 or .1 depending on what IO base the ISA IDE adapter uses.
>
> Seeing as Q40 support in the atari-falcon-ide has been broken since it was
> introduced, this is rather about future installer support than about
> inadvertently breaking current code.
>
> Cheers,
>
>     Michael
>
> On 21/08/23 23:08, Finn Thain wrote:
> > On Mon, 21 Aug 2023, Geert Uytterhoeven wrote:
> >
> >> On Sat, Aug 19, 2023 at 1:53 AM Finn Thain <fthain@linux-m68k.org> wrote:
> >>> On Fri, 18 Aug 2023, Geert Uytterhoeven wrote:
> >>>> Of course 0 also works, but causes ".0" to be appended to the platform
> >>>> device's name, visible in e.g. /sys/bus/platform/devices/.
> >>> That seems desirable to me.
> >> Why would it be desirable?
> >> IMHO this is an unneeded change which is visible in userspace.
> >>
> > Only so what's visible in userspace would be consistent across atari and
> > q40 (and anything else that happens to instantiate the device in future).
> >
> > Basically, I don't really understand why id -1 is better than id 0. I've
> > searched Documentation/device-tree and I still don't understand why a
> > singleton would need a special bus id.
>