From: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH 07/15] m68k: convert to setup_initial_init_mm()
Date: Wed, 2 Jun 2021 23:13:14 +1000 [thread overview]
Message-ID: <8305967a-4e1f-489e-e04a-cde8f8b5693d@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdVvbA-bJCubhmKaJ_4VbKo+U538x7s34OkZ94kL7z4nrw@mail.gmail.com>
On 31/5/21 5:48 pm, Geert Uytterhoeven wrote:
> Hi Kefeng
>
> (CC Greg for m68knommu)
>
> On Sat, May 29, 2021 at 12:46 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Use setup_initial_init_mm() helper to simplify code.
>>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: linux-m68k@lists.linux-m68k.org
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Thanks for your patch!
>
>> --- a/arch/m68k/kernel/setup_mm.c
>> +++ b/arch/m68k/kernel/setup_mm.c
>> @@ -258,10 +258,7 @@ void __init setup_arch(char **cmdline_p)
>> }
>> }
>>
>> - init_mm.start_code = PAGE_OFFSET;
>> - init_mm.end_code = (unsigned long)_etext;
>> - init_mm.end_data = (unsigned long)_edata;
>> - init_mm.brk = (unsigned long)_end;
>> + setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end);
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>> --- a/arch/m68k/kernel/setup_no.c
>> +++ b/arch/m68k/kernel/setup_no.c
>> @@ -87,10 +87,7 @@ void __init setup_arch(char **cmdline_p)
>> memory_start = PAGE_ALIGN(_ramstart);
>> memory_end = _ramend;
>>
>> - init_mm.start_code = (unsigned long) &_stext;
>> - init_mm.end_code = (unsigned long) &_etext;
>> - init_mm.end_data = (unsigned long) &_edata;
>> - init_mm.brk = (unsigned long) 0;
>> + setup_initial_init_mm(_stext, _etext, _edata, (void *)0);
>
> Please use NULL instead of (void *)0.
With that in place, no problems I see.
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2021-06-02 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210529105504.180544-1-wangkefeng.wang@huawei.com>
2021-05-29 10:54 ` [PATCH 07/15] m68k: convert to setup_initial_init_mm() Kefeng Wang
2021-05-31 7:48 ` Geert Uytterhoeven
2021-06-02 13:13 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8305967a-4e1f-489e-e04a-cde8f8b5693d@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox