Re: esp_scsi QTAG in FAS216

Finn Thain
2016-10-31T23:47:37Z

On Tue, 1 Nov 2016, Michael Schmitz wrote:

> > I had tried to set that bit in zorro_esp_slave_configure but had not
> > done a proper job of it - I'd only set esp->config3 and forgot to set
> > tp->esp_config3. Time to retest this ...
>
> I don't think it's quite that easy - the ESP_CONFIG3_TENB bit needs to
> be set for all targets if at least one SCSI-2 target is on the bus and
> we allow dosconnecting, no?

I think ESP_CONFIG3_TENB is for FAS100A and FASHME. The bug here is on
ESP236 and FAS236, so ESP_CONFIG3_TBMS would be the relevant bit.

The bit gets set when ESP_CONFIG2_SCSI2ENAB gets set (as in David's
patch) so we then need to avoid clobbering it, since ESP_CONFIG3_TBMS ==
ESP_CONFIG3_EWIDE. I think we have to test for HME to avoid this clash.

--

>
> Adrian - any chance I can get access to elgar again for some more testing?
>
> Cheers,
>
> Michael