public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] m68k: pgtable: Add missing #include <asm/page.h>
Date: Thu, 07 Mar 2024 12:12:45 +0200	[thread overview]
Message-ID: <8734t2xsde.fsf@intel.com> (raw)
In-Reply-To: <ba359be013f379ff10f3afcea13e2f78dd9717be.1709804021.git.geert@linux-m68k.org>

On Thu, 07 Mar 2024, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> When just including <linux/pgtable.h>:
>
>     include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name ‘pgd_t’
> 	9 | typedef struct { pgd_t pgd; } p4d_t;
> 	  |                  ^~~~~
>
> Make <asm/pgtable.h> self-contained by including <asm/page.h>.
>
> Reported-by: Jani Nikula <jani.nikula@intel.com>
> Closes: https://lore.kernel.org/r/878r2uxwha.fsf@intel.com
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Jani: Feel free to pick this up as a dependency.
> Else I will queue this in the m68k tree for v6.10.

Thanks, I'd like to pick this up as a dependency, so I can proceed with
my series. It'll also be queued for v6.10 via the drm subsystem.

BR,
Jani.


>
>  arch/m68k/include/asm/pgtable.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/m68k/include/asm/pgtable.h b/arch/m68k/include/asm/pgtable.h
> index 27525c6a12fd0c7f..49fcfd7348600594 100644
> --- a/arch/m68k/include/asm/pgtable.h
> +++ b/arch/m68k/include/asm/pgtable.h
> @@ -2,6 +2,8 @@
>  #ifndef __M68K_PGTABLE_H
>  #define __M68K_PGTABLE_H
>  
> +#include <asm/page.h>
> +
>  #ifdef __uClinux__
>  #include <asm/pgtable_no.h>
>  #else

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-03-07 10:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  9:35 [PATCH] m68k: pgtable: Add missing #include <asm/page.h> Geert Uytterhoeven
2024-03-07 10:12 ` Jani Nikula [this message]
2024-03-14 10:28   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734t2xsde.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox