From: Andreas Schwab <schwab@linux-m68k.org>
To: Defang Bo <bodefang@126.com>
Cc: gerg@linux-m68k.org, geert@linux-m68k.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL
Date: Sun, 27 Dec 2020 16:47:20 +0100 [thread overview]
Message-ID: <87bleffdyv.fsf@igel.home> (raw)
In-Reply-To: <1609079753-4038536-1-git-send-email-bodefang@126.com> (Defang Bo's message of "Sun, 27 Dec 2020 22:35:53 +0800")
On Dez 27 2020, Defang Bo wrote:
> diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c
> index 7bc666e..cf1ed97 100644
> --- a/arch/m68k/coldfire/clk.c
> +++ b/arch/m68k/coldfire/clk.c
> @@ -90,6 +90,9 @@ EXPORT_SYMBOL(clk_get);
> int clk_enable(struct clk *clk)
> {
> unsigned long flags;
> + if (!clk)
> + return;
That fails to return a value.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
parent reply other threads:[~2020-12-27 15:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1609079753-4038536-1-git-send-email-bodefang@126.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bleffdyv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=bodefang@126.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox